Repository navigation
ci: enable merge_group trigger; bump stdlib minimum to 0.0.11 - #114
Merged
Merged
Conversation
Picked up from #113. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Allows the minimal-check job to run on the merge queue synthetic gh-readonly-queue/main/* refs in addition to pull_request events. Required before adding a merge_queue rule to the branch ruleset since the queue needs an event-driven workflow to gate its merges. Workflow change is independent of the policy change. Landing this PR alone does not enable the queue or change merge requirements; that happens via a follow-up ruleset update once this is in main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR extends the CI workflow to include GitHub merge queue operations and updates the minimum stdlib version requirement from 0.0.9 to 0.0.11, maintaining compatibility with newer dependency versions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
twitchyliquid64
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes bundled because the second one needs to land before the merge queue ruleset can be enabled, and the first is a small prerequisite that was already approved on its own PR.
1. Bump stdlib minimum to 0.0.11 (picked up from #113)
Required for the
license_spdxattribute Tom added to package definitions.2. Enable
merge_groupevent trigger on CIAllows
minimal-checkto run on the merge queue's synthetic refs (gh-readonly-queue/main/*) in addition to PR events. Required as a precondition before adding amerge_queuerule to the branch ruleset — the queue needs an event-driven workflow to gate its merges.Important: this PR alone does not enable the merge queue or change merge requirements. It only makes CI runnable on merge_group events. The actual policy change (enable queue, require minimal-check, require branches up to date) happens via a follow-up ruleset PATCH on
repos/gominimal/pkgs/rulesets/14240756.Why
Pkgs's index race (which caused the openssl 3.6.2 cache-poisoning incident) is fixed at the writer level by gominimal/minimal#155 (CAS via
if_generation_match). But there's a related class of issues — stale-PR cache pollution — where a PR built against an older view of dependencies uploads artifacts whose spec_hash doesn't match what post-merge main computes. Merge queue +strict_required_status_checks_policy: trueforces every merged PR to be tested against latest main, eliminating that source of cache misses.Plan after this PR lands:
14240756to addrequired_status_checks(withstrict_required_status_checks_policy: true) andmerge_queuerules.Closes #113.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit