8000 fix(minimal): name the layer that set secrets in min box spec refusals · gominimal/minimal@7dd1869 · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): name the layer that set secrets in min box spec refusals

Minimal Arch / arch-review succeeded Nov 14, 2026

PASS

Baseline. This re-reviews 7dd18695 against the CONDITIONS on 6402c829 (this PR), on arch 15b603e6. The checkout has no arch-map.md, so I found the sections by search, as the earlier rulings did. The ledger entry for 6402c829 is cut off after its first lines, so I could not read its conditions word for word. It cites lines 1205, 1208 and 1228–1234 of minimal.toml layout. since.diff holds one merge of main (023e4e55) and two PR commits, dad16066 and 7dd18695. I reviewed only the PR commits (git diff 023e4e55 HEAD). The merged main content is not this PR's change.

Governs. minimal.toml layout, line 1205: [defaults.<type>] applies only to entries of that type. Line 1231: the expansion order. Line 1234: a table replaces the one below it wholesale.

Ruling. dad16066 puts the table name into each BepRefusal as a field from BepTables. The fixed [defaults.session.*] text is gone. 7dd18695 makes min box spec <entry> pass the table of the layer that set secrets or network, from the ExpansionReport origin. [defaults] gives [defaults.<k>], [defaults.<type>] gives [defaults.<type>.<k>], and the implicit entry also gives [defaults.<type>.<k>]. Any other origin gives the entry's own table. Box Type defaults fall to the entry table, which beats them, so the edit takes effect. expand_entry builds its layers with Layers::default().with_file_defaults(...), so the report has no Loadouts or Overrides origin. No named table can sit below a layer that hides the edit. min box start reads file.session in project_bep_and_grants, and its refusals name [defaults.session.*]. That is the table the start path reads. bep_refusals_name_the_minimal_toml_table and box_spec_task_entry_refusal_names_the_task_secrets_table pin the session tables and also [tasks.ci.*] and [boxes.dev.*]. I found no deviation.

Not in this ruling. The start path ignores an entry's own secrets for every entry. That gap existed before this PR, and this task does not cover it. crates/minimal/src/tests.rs is outside the task's layers:. That is a plan question, not a design deviation. The failed agent-verify test (exec_run_attach_and_task_run_share_the_commands_trace) is in OTel tracing, which this diff does not touch.

Not checked. I did not compile or run the tests, and I did not run scripts/session-e2e.sh. That script needs a VM.

Ruled at 7dd1869 against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1296, job 19cd7317-bb8a-4657-9bb2-4729181046a3.

0