8000 fix(minimal): drop hooks from the expanded spec under --no-hooks · gominimal/minimal@804ea4a · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): drop hooks from the expanded spec under --no-hooks

Minimal Arch / arch-review completed Nov 13, 2026 in 0s

PASS_WITH_CONDITIONS

Baseline. This re-reviews 804ea4a5 against the CONDITIONS on 529a45fc (this PR), on arch 15b603e6. The checkout has no arch-map.md, so I found the sections by search, as the earlier rulings did. The ledger cuts the baseline's conditions, so I checked the full pr.diff again. since.diff is a merge of main (084097eb, which brings 8e3ef2de) and one PR commit, 804ea4a5. git show --cc 084097eb shows no conflict edits, and pr.diff touches only expand.rs, spec.rs, create.rs and tests.rs. 804ea4a5 removes lifecycle_hooks from the expanded spec under --no-hooks, and restores the task_box_entry() comment that names #3302.

Governs. minimal.toml layout, architecture.md line 1231: the expansion order ends entry → selected loadouts → command-line overrides. Line 1234: project hooks compose first, then each selected loadout's. Lines 1151–1153: --no-hooks empties the list, so the stored spec carries none. Policy layers and precedence, lines 1285–1286: selected loadouts subject to loadout_mode, then the overrides, --no-hooks included. The repo spec BOX-179 (docs/specs/29, line 468) gives the declared_by shape.

Ruling. The work is in the owner that the design gives it. The fold in mfile::expand writes the declarer. The client's box_entry() builds the selected-loadouts layer after the gate in activate_box(). One Origin::loadout(name) layer per loadout keeps the order of lines 1231 and 1234, and the report records each hook's layer and loadout. The fold replaces a forged declared_by, and a test proves it. The wire strips declared_by, so the daemon's composition and its deny_unknown_fields check do not change. A per-loadout layer makes two loadouts that disagree a BOX-183 conflict that names both, and one loadout that sets a name twice a BOX-184 error that names it. The design is silent on that split, and the repo spec text admits it. The one condition is bookkeeping. The PR body says to close #3302 on merge. The code still names #3302 for the min task run leg, and that work would have no owner.

Not checked. I did not compile or run the tests. The verify run in the PR body failed minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace. That test is not in the changed code paths, and I did not establish whether it is a flake. I was not able to open #3257, #3302 or #3236 (no gh in the sandbox). They are named in the tree at crates/boxes/src/wire/request.rs, create.rs and box_spec.rs.

Conditions

  • C1: PR body (pr.json body): change "This task finishes the work #3282 and #3302 track. Close both by hand when it merges." so that only #3282 closes on merge. Keep #3302 open. crates/minimal/src/cmd/boxes/create.rs task_box_entry() (head line 1647) still names #3302 as the open gap: min task run sends SelectedLoadouts::default(), so an open task gets no selected-loadouts layer in its client expansion and no BOX-183 refusal before create. If #3302 must close, file a new issue for the min task run leg first and put its number in that comment.

Ruled at 804ea4a against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1266, job 1a87d536-312a-4549-a88b-d1a71f0fe84e.

0