8000 Merge remote-tracking branch 'origin/main' into agent/3346-min-box-events-parent-follow-adds-the-stream-of · gominimal/minimal@14e31d6 · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into agent/3346-min-box-ev…

Minimal Arch / arch-review succeeded Nov 13, 2026 in 0s

PASS

Baseline. This re-reviews 14e31d61 against the PASS on 210b6094 (this PR), on arch 15b603e6. The checkout has no arch-map.md, so I found the sections by search, as the earlier rulings did. since.diff has two parts. The merge of main (14e31d61, which brings 767d9bea, #3390) brings in crates/boxes/src/store.rs. git show --cc shows no conflict edits, and pr.diff does not include that file. Commit 1cab2c0e changes only ChildWatch::new_children in crates/minimal/src/cmd/boxes/events.rs. The baseline ruling stands for everything that the compare does not touch.

Governs. architecture.md line 504: min box events --parent self --follow merges all children onto one stream. Line 502: --follow replays then tails, so a late reader misses nothing.

Ruling. A failed re-list no longer ends the follow at once. list_failures counts failures in a row, and a good listing sets it back to zero. Below CHILD_LIST_TRIES (5), the poll returns no new reads, and the follow keeps its open streams. The fifth failure in a row ends the command with the same error text as before. This is the same bounded-retry shape as CHILD_OPEN_TRIES, which the baseline accepted. The follow fails closed: it ends with an error and does not hide a gap (rule 7). A child created during the outage still has seen unset, so the next good listing opens it with replay (line 502). The failed open counts do not change on a failed listing. The user-facing error text did not change, and tracing::warn! now adds a tries field. That is a log field, not a design-named audit field. findings.json is not staged.

Not checked. No test exercises the list-outage path. The task proof does not require one, and I did not build or run the tests. The agent-verify failure in the PR body is otel_cli exec_run_attach_and_task_run_share_the_commands_trace, and this change does not touch that path. The design does not state a retry bound, so I make no claim about the value 5.

Ruled at 14e31d6 against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1256, job f089d8f4-3cc2-4ae1-a776-0d47c332c809.

0