8000 test(minimal): list the vpn-names refusal test in the create inventory · gominimal/minimal@c5208e5 · GitHub
[go: up one dir, main page]

Skip to content

test(minimal): list the vpn-names refusal test in the create inventory

Minimal Arch / arch-review completed Nov 11, 2026 in 0s

PASS_WITH_CONDITIONS

Baseline. This re-reviews c5208e53 against the PASS_WITH_CONDITIONS on 8e85ff4c (this PR), on the same arch 15b603e6. since.diff adds one line to every_create_session_asserts_the_daemon_build: the new test vpn_network_names_without_a_spec_is_refused joins the list of unit requests that are never sent. That changes no behaviour, so the earlier ruling stands for every other line. The ledger cuts each why at 400 characters, so I could not read the conditions on 8e85ff4c. I re-derived the open items from the head. Any condition of that ruling that this document does not restate still stands.

Governs. architecture.md Type nouns (lines 453–458): every start and run takes an override flag for each [network] key, named after the key, as the last expansion layer. A list flag adds and a scalar flag replaces. --no-hooks empties the composed hook list, so the stored spec carries none. --no-loadouts applies no loadout, and giving it with --loadout is exit 2. Policy layers and precedence line 1286 puts these flags in layer 7. The checkout has no arch-map.md, so I found the sections by search. Spec 29 BOX-064 (lines 355–373) now states the command-line layer rules, including the no-hooks sub-bullet, so the spec and the design agree (rule 9 is clear).

Ruling. The flags sit in the client (cli.rs, create.rs, task.rs), which owns the command-line layer (rule 8). Dynamic ingress off own_ip refuses with activate's message. The run path now uses admit_declaring for host_ip residency with --credentialed-upstream, as activate does. A spec-less run refuses --vpn-network-names instead of dropping it (rule 7). On the run path, hooks_enabled is set before spec_flags reads it, so the stored v0 spec keeps hooks off. C1 asks for a test that proves that (rule 3). The run path's missing --ingress and --loadout, and the box spec <entry> clause of BCLI-075 and BCLI-076, are filed residuals (#3163, #3237, #2906).

Not checked. I did not compile or run the tests. The PR body's "Gaps for a later task" section is truncated in pr.json, so I could not compare it with the residuals above. I took #2906 as the owner of the box spec <entry> form from the branch name agent/2906-render-an-entry-s-or-a-box-s-expanded-spec and its commit text. I took #3163 and #3237 from code comments. I could not open the issues because gh is not available here.

Conditions

  • C1: crates/minimal/src/tests.rs start_no_hooks_stores_no_hooks: after assert!(run.other.no_hooks), build the run request as task::run_entry builds it. Set request.config.hooks_enabled = !run.other.no_hooks, build the spec from crate::spec_flags(&request), call put_spec, and assert that the spec's hooks_enabled is false for min task run --no-hooks and min box run --no-hooks. The test now proves only that the flag parses on the run path. It does not prove that the stored spec of a run box carries no hook.

Ruled at c5208e5 against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1155, job af9852ea-9c30-4c5a-a473-81cf417cca85.

0