8000 test(minimal): hold the whole shipped box-types table in the fixture · gominimal/minimal@775d587 · GitHub
[go: up one dir, main page]

Skip to content

test(minimal): hold the whole shipped box-types table in the fixture

Minimal Arch 3C18 / arch-review failed Nov 11, 2026

CONDITIONS

Governs (architecture.md at arch 15b603e6. The checkout has no arch-map.md, so I found the sections by search.) Type nouns line 463: min type list shows every resolvable type with its source, and min type show renders the resolved definition, its extends chain and its source. Output conventions line 381: -o json objects carry min/v1/<type>. minimal.toml layout lines 1212-1224: the shipped types' table, where only — cells are not applicable.

Baseline. This re-reviews 775d5873 against the CONDITIONS on 0bfd4c16. since.diff touches only architecture_builtin_table() in crates/minimal/src/tests.rs. It removes the note that the design is not in the repository and fills the fixture from the table. I checked each cell against lines 1216-1222: pty_enabled, exec_enabled, lifetime, loadout_mode, [nesting] allowed and timeout match, with each (constrains) cell a constraint. Everything else in pr.diff keeps the status of the baseline ruling. I also re-read the CLI model, the dispatch, types.rs and the cli-min.md hunk against line 463, and found no new deviation.

Ruling. The fixture still leaves out two rows that are not — cells: [execution] restart = never for service (line 1223) and github_token_mode for every type (line 1224). Line 1208 lists both among the defaults a type supplies, and mfile knows both keys (crates/mfile/src/expand.rs lines 477 and 499). The doc comment says only the — cells and on_oom are left out, so the proof does not test the whole table it cites (rubric rule 3). C1 adds the two rows. The empty built-in defaults are an honest interim: the test is #[ignore] on #3294 and the PR notes name the flip, so they stay a residual.

Not checked. The ledger entries for the earlier heads are cut at 400 characters, so I could not read the conditions of 0bfd4c16 in full. I ruled on the whole diff myself. Whether the fixture's flat key spelling (exec_enabled, nesting.allowed) matches what type_detail prints for built-in values depends on how #3294 spells them in mfile::box_types, and that is settled when the test is un-ignored. I did not build or run the tests.

Conditions

  • C1: crates/minimal/src/tests.rs architecture_builtin_table(): add the two rows of the shipped-types table that the fixture leaves out. Add ("restart", "\"never\"") to the service defaults. Add github_token_mode to the defaults of every type: "user" for session, task and agent, and "installation" for service, build and container-build. Leave out only the — cells and the proposed on_oom row, as the doc comment above the function says. Do not change type_show_matches_shipped_table_with_sources or its #[ignore] on #3294.

Ruled at 775d587 against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1156, job 0bf2cbb0-12b2-4411-bda2-76900df80896.

0