8000 fix(minimald): adopt only activation forwards at the current publish · gominimal/minimal@281e69b · GitHub
[go: up one dir, main page]

Skip to content

fix(minimald): adopt only activation forwards at the current publish

Minimal Arch / arch-review failed Nov 21, 2026

CONDITIONS

Inputs. Re-review of #3703 at 281e69b8, on arch 4f2eb87d (the same arch commit as the baseline). The baseline is the CONDITIONS ruling at 0062a4e2, whose C1 and C2 are in since-conditions.json. since.diff holds one merge of main (#3690 and #3694, in files outside pr.diff) and one fix commit, 281e69b8, which changes only crates/minimald/src/net/gvproxy_network.rs. No findings.json or arch-map.md is staged.

Governs: §7.1 Enforcement parity, line 255. A forwarder bind succeeds before the name is published, and a failed bind is a surfaced error, never a silent fallback.

Conditions from the baseline.

  • C2: met. The new adopt_activation_forwards keeps only an activation forward that PortForwarder::is_forward_of(published, mapping) matches for a declared mapping that the box does not yield now. It unbinds every other one with unbind_moved. It binds the missing mappings through apply_ingress_naming_holders toward lease_ip, and it unbinds the kept forwards when that bind fails. The attach then withdraws the name, as the (Some(ingress), Some(published)) arm does. The test native_attach_binds_the_forwards_a_moved_publish_left_unbound binds one forward at an old address and proves the unbind and the rebind at the current address. It uses 127.0.0.16 as the old address, not 127.0.0.1. That proves the same rule.
  • C1: open. setup.rs did not change in the compare. The Some(Err(e)) arm still logs tracing::warn!, runs host_ports_in_use and lets the finalize continue with no declared port bound. host_ports_in_use still has that caller.

Ruling. Placement and the adopt path conform. The silent fallback at a failed switch start is still the deviation from line 255 that C1 names. C1 is carried forward with its text unchanged.

Not checked: that the test passes. That needs a build.

Conditions

  • C1: crates/minimald/src/box_actor/setup.rs, native (false, _) arm of the finalize publish check: in the Some(Err(e)) branch (the switch did not start at activation), return the error so the finalize fails, as the VM-backed arm does for a failed bind that is not a held port (None => return Err(e)). Remove the tracing::warn! and the host_ports_in_use fallback probe there. When no caller of crate::net::policy::host_ports_in_use stays outside its tests, remove the function and its tests, as the task's net layer says. Tests that finalize a native own-IP box with declared ingress and no gvproxy use SwitchClient::serve_externally or a stand-in switch.

Ruled at 281e69b against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5; arch_rulings 1581, job 3d7a3798-7550-4c99-809e-39fe3bd33b40.

0