8000 Merge remote-tracking branch 'origin/main' into agent/2917-remove-the-old-session-verbs-and-move-their-call · gominimal/minimal@9ca75a9 · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into agent/2917-remove-the…

Minimal Arch / arch-review failed Nov 20, 2026 in 0s

CONDITIONS

Inputs. Second ruling at 9ca75a93, on arch 8b824707. The ledger has a CONDITIONS ruling on this same head. No since.diff, since-conditions.json, findings.json or arch-map.md is staged, so I cannot see that ruling's conditions. I read the full change (14b57239...9ca75a93, 30 files) and ruled on all of it. The PR body says the earlier C1 was README.md and docs/guide. The author filed it as #3685. I accept it as a residual, which is a departure from that ruling only in form: the head is the same, and the design is silent on README and the guide. I did not verify that #3685 exists (no network).

Governs: architecture.md principle 3 (line 333), principle 8 (line 338), exit codes (line 363), Top-level commands (line 442), Type nouns (lines 453, 458), host stop (line 555).

Ruling. The grammar change conforms. SessionCommand now has only the verbs of line 453, plus the hidden setup-zed. Bare min stop and task run --path are gone, the parse fails with exit 2, and cmd/session.rs has no dead handlers left. kept_session_list_and_attach_still_work and removed_session_verbs_fail_as_unknown_commands pin both sides. The spec's verify line names the second. The installer conforms to line 555. It stops only local and local-minvmd hosts, refuses a failed or partial listing, and falls back to bare min stop only when min host stop --help fails. Callers are not all moved. C1: the no-TTY min report in cmd/list.rs, a file this PR edits, prints min session run and min session activate --attach . as the next commands. C2: fifteen other product messages name min stop, min session activate|destroy|exec. Most are outside the layers and the 30-file cap, so filing them is enough.

Escalation E1. Line 458 keeps min session activate --sync until gominimal/arch#163 rules. BCLI-042 removes it on a later owner ruling. At this head no command takes --sync, and the dropped-hooks refusal names that flag (principle 3). The PR cannot amend the design, so this parks for a person. It is not a FAIL.

Not checked. I did not build or run tests. The PR's earlier note that 14 integration tests failed is out of date: those tests now run session start. I did not prove that they pass. I did not check whether a pending or materializing box survives min host stop. Spec 07 R5.5 refuses on running only, and the design does not speak to the installer.

Conditions

  • C1: crates/minimal/src/cmd/list.rs render_bare_status() (lines 183-188): the Next: lines name min session run <session> <task> and min session activate --attach ., and both now fail with exit 2. Print min task run <task> for the first, and min session start for the second. Update the unit tests that pin those lines verbatim in the same commit. Also fix the comment in cmd_bare() (line 54) that says the create path is min session activate --attach ..
  • C2: Every other product message that still tells the user to run a removed spelling must name the successor, or be filed as a residual with an issue. The sites at this head are: crates/minimal/src/autospawn.rs:344, crates/minvmd/src/cmd/answerer.rs:202, crates/minvmd/src/cmd/run.rs:488, crates/minimal-client/src/box_registration.rs:344 and :1632 and crates/minimal/src/dash/render.rs:639 (min stop → min host stop <host>); crates/minimal/src/cmd/project.rs:1200, :1252, :1271 and crates/minimal/src/dash/rpc.rs:630 (min session activate → min session start); crates/minimald/src/box_actor/attach.rs:289-291, crates/minimald/src/box_actor/host.rs:1233-1234, crates/minimald/src/net/answerer.rs:1651, crates/minimald/src/exec/process.rs:252-253 (min session destroy → min box rm --force, min session activate → min session start); crates/minimal-client/src/attach.rs:1292 (min session exec → min box exec). Most of these files are outside T31's layers and its 30-file cap. So file one issue (or widen #3685) that lists them, and name it under ## Residuals in the PR body. Leave the --sync remedies in cmd/project.rs:376-382 to escalation E1.

Needs a design decision

  • architecture.md line 458 says that start and run take no sync flag until gominimal/arch#163 rules, and that meanwhile the shipped min session activate --sync stays on its alias (owner ruling 2026-11-06). Spec 28 BCLI-042 and its Non-goals (line 613) remove min session activate with no alias, per a later owner ruling (2026-11-09), and this PR does that. At this head no command takes --sync. So a project in $HOME or an empty directory cannot upload, and the refusal remedies in crates/minimal/src/cmd/project.rs (CLI_DROPPED_HOOKS_REMEDY, DASH_DROPPED_HOOKS_REMEDY) name --sync tarball and min session activate --sync tarball, which now fail with exit 2. Line 333 (principle 3) requires a refusal to name a flag that answers it. Which decision holds: amend line 458 to drop the --sync alias (and then what must the remedy say), or keep a sync flag somewhere until arch#163 rules?

Ruled at 9ca75a9 against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1559, job 4f9bbc25-8faa-486b-aa38-c00682c1ad47.

0