8000 Merge remote-tracking branch 'origin/main' into m3593c · gominimal/minimal@d929dac · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into m3593c

Minimal Arch / arch-review succeeded Nov 20, 2026 in 0s

PASS

Inputs. Re-review of #3593 at d929dac5, on arch 8b824707, the same arch commit as the baseline PASS at 5cd03066. since-conditions.json is empty, and the latest ruling on this PR is a PASS, so no condition is open and the compare is enough. No findings.json and no arch-map.md are staged. I found the sections by search, as the earlier rulings did.

What changed. d929dac5 is a merge of origin/main (626761a6) into 5cd03066. since.diff equals git diff 5cd03066..d929dac5, and pr.diff equals git diff 626761a6..d929dac5. All 58 files in the compare are files that main changed between the old merge base fae1e91c and 626761a6. The PR's own added and removed lines (git diff -U0) are byte-identical before and after the merge (13 files, +1028/−183). Only hunk context differs. For the six files that both sides touch, the merge result equals main plus the PR's lines, so main's edits survive whole.

Interaction check. I searched main's incoming changes for new injection paths (nsenter, command_in_session, InjectedCommands, setns, leaf or classifier). There are none. The restart work (#3661, stop_box_for_restart in box_actor/host.rs) reuses the existing stop and start paths. The connection.rs and attach.rs edits change a refusal status and its text only. The one classifier hit is a comment in the sandbox's cgroup2 cover retry, which is the box launch, not an injection.

Governs. Architecture, Box Resources, lines 1361 and 1363: exec commands and lifecycle hooks run in the box's cgroup, and a process joins that cgroup before it enters any of the box's namespaces. Egress design §4.1 line 54: processes outside the boxes subtree take the node-plane address. So a box process left in the daemon's leaf would egress as the node plane. Ruling. The ruling at 5cd03066 stands for both NET-079 sub-requirements, because the compare does not touch them. No departure from precedent.

Not checked. No build or test, per the contract. The PR body says that nothing has run against a real cgroup yet, and that just test-cross and just e2e did not run locally. CI lanes carry those.

Ruled at d929dac against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1546, job 76e72e6c-aebb-4f44-9d6d-7f2aa7548f7f.

0