8000 fix(minimal-client): read an unreachable host as the shell's own row-ended status · gominimal/minimal@7ba4b45 · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal-client): read an unreachable host as the shell's own row-…

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. Re-review of #3615 at 7ba4b45d on arch 8b824707, the same arch as every earlier ruling on this PR. The latest ruling that is not a FAIL or a CONFIRM is the PASS at 62f4ba2d. since-conditions.json is empty after that PASS, so no condition is open and the compare is enough. I checked that since.diff equals git diff 62f4ba2d..7ba4b45d. It is one commit in crates/minimal-client/src/box_registration.rs. No findings.json or arch-map.md is staged.

Governs: architecture.md, Exit codes (lines 357–368: 1 is an unspecified error, 7 is provider/host unreachable). Spec 18 NET-138 has the sub-requirement for the row-ended retry.

Ruling. box_row_withdrawn now matches Ok(Ok(Err(_))) from attach::box_row_stands_at. That function returns Err only for HostUnreachable. The new arm logs a warn! and returns Ok(false), the same as the timeout arm that the PASS at be7afdbf accepted. attach_retrying_row_ended then returns the attach's own 253 and does not call the resume. The dashboard already maps any error to false through .unwrap_or(false), so this commit does not change the dashboard. Before this commit, the CLI attach ended with exit 7 through main.rs's HostUnreachable mapping. The path that cannot decide takes no action and keeps the status it saw. That is fail closed (rule 7). The design gives no line that makes an auxiliary read's failure replace the attach's status. The new test box_row_withdrawn_reads_an_unreachable_host_as_the_shells_status drops the listener and keeps the socket file. So it gets past the control.exists() early return and drives the unreachable arm (rule 3).

Note for the next reviewer (not an architecture condition). The doc comment on ROW_ENDED_ATTACH in crates/minimal/src/cmd/boxes/attach.rs lists the cases where min exits 253. It does not yet list an unreachable VM host or a read that times out. This is code quality, for minimal-review.

Not checked: the behaviour at runtime. That needs a build, which is out of bounds.

Ruled at 7ba4b45 against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1514, job 378cf882-8ef7-476a-9073-8a61d0c6cb54.

0