8000 fix(minimal): refuse finalize-install on a bad provider, spare --undo · gominimal/minimal@73cb2a9 · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): refuse finalize-install on a bad provider, spare --undo

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. Re-review of #3644 at 73cb2a96, on arch 8b824707, the same arch as every earlier ruling on this PR. The baseline is the CONDITIONS at 78fe2610. since-conditions.json carries its C1, and since.diff starts at 78fe2610. The compare is one commit, 73cb2a96, and it touches only crates/minimal/src/cmd/mod.rs needs_provider() and the test an_unknown_min_provider_spares_commands_that_need_no_provider in crates/minimal/tests/cli.rs. No findings.json or arch-map.md is staged.

Governs: architecture.md Global flags and environment (line 352): MIN_PROVIDER names the target provider. The min CLI: Design principles item 7 (line 337): safe by default. A command that installs host changes for a provider must not run when the provider does not resolve.

Conditions.

  • C1 — met. needs_provider() no longer exempts Command::FinalizeInstall(_). It exempts only Command::FinalizeInstall(FinalizeInstallArgs { undo: true, .. }). I opened crates/minimal/src/cmd/finalize_install.rs: cmd_finalize_install sends --undo to cmd_finalize_install_undo(args.show) before plan_for_this_host(global, …), and the undo path reads no provider. So the exemption is exact. The test now asserts that finalize-install with MIN_PROVIDER=bogus exits non-zero and prints the exact refusal line, and that finalize-install --undo --show --script does not print it. C1 named finalize-install --show for the assertion. The test uses bare finalize-install. The gate in needs_provider() reads only undo, so the bare form proves the same rule, and the refusal comes before any root step runs. I accept it as met.

Ruling. Every open condition is met. The baseline PASS at 29ddd460 stands for everything the compares do not touch. The Linux Box Egress Proxy e2e leg stays NOT RUN, and it is carried as a residual owned by #3652, as the PR body declares.

Not checked. I did not build or run the tests. That the test passes is the author's claim, not mine.

Ruled at 73cb2a9 against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1506, job b101b691-29a6-442f-86db-bb661693acda.

0