8000 fix(minimal): name the provider variable MIN_PROVIDER, as architecture.md does · gominimal/minimal@29ddd46 · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): name the provider variable MIN_PROVIDER, as architectur…

Minimal Arch / arch-review succeeded Nov 19, 2026

PASS

Inputs. Re-review of #3644 at 29ddd460, on arch 8b824707, the same arch as the baseline CONDITIONS at 2f598b39. since.diff starts at 2f598b39. since-conditions.json carries C1 and C2 of that ruling. No findings.json or arch-map.md is staged.

Governs: architecture.md Global flags and environment (line 352), which names MIN_PROVIDER as the variable for --provider. D6 (line 772) and Deployment Styles: LocalVM (line 1436) put the Box Egress Proxy on the host OS, outside the VM.

Conditions.

  • C1: met. hosts.rs PROVIDER_ENV is "MIN_PROVIDER". The doc comments in hosts.rs, cli.rs, cmd/mod.rs, finalize_install.rs and client-config/src/config.rs say MIN_PROVIDER. The pinned refusal text in default_provider_tests::unknown_provider_values_are_refused and the renamed an_unknown_min_provider_refuses_flagless_commands_only say MIN_PROVIDER. tests/cli.rs, tests/git_remote.rs, tests/otel_cli.rs, scripts/session-e2e.sh (line 861), docs/reference/cli-min.md and existing-provider-surface.md are updated. A search of the head tree finds no MINIMAL_PROVIDER and no alias.
  • C2: met. Issue #3652 owns the Linux live legs. The Linux not_run reason in bep_live_gate() (line 14043) names it, and the PR body names it as the residual.

Ruling. The compare edits only the lines that C1 and C2 name. The rest of the change keeps the status that the baseline gave it. Both requirements conform. The Linux live Box Egress Proxy legs stay NOT RUN. They are open, not passed (rubric rule 4). They are a filed residual (#3652), as the baseline asked, so they do not hold this ruling. This follows the baseline and does not depart from it.

Not checked. I did not compile or run the tests. The rename is textual, and a search of the tree confirms it.

Ruled at 29ddd46 against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1497, job d96bc633-e8ae-4e4a-a063-ee9ffb244792.

0