8000 ci(release): build and upload bep for the linux releases · gominimal/minimal@2f598b3 · GitHub
[go: up one dir, main page]

Skip to content

ci(release): build and upload bep for the linux releases

Minimal Arch / arch-review failed Nov 19, 2026 in 0s

CONDITIONS

Governs: architecture.md Global flags and environment (line 352), Glossary: Well-Known Local Box Providers (line 53), Deployment Styles LocalVM (line 1436) and SharedLinux (line 1578), D6 Hosted or node-local (line 772), and Gatehouse §6.10 Hardware-backed custody (line 837). No arch-map.md, findings.json, since.diff or since-conditions.json is staged. This is the first ruling on #3644, so I read pr.diff whole.

Ruling. The new Linux default conforms. The design offers local-minvmd on Linux and calls SharedLinux far less secure and not recommended. A VM default where /dev/kvm opens, with local as the fallback, follows that ranking. --provider still wins over every default. Unknown values and unreadable config refuse the command, so the resolver fails closed. Starting bep serve from minvmd on Linux matches LocalVM and D6: the node-local BEP runs on the host OS, outside the VM, on macOS or Linux. TPM 2.0 custody with a Secret Service fallback meets the §6.10 SHOULD. A missing or refused proxy binds no lane. Two items stay open. C1: the design names the environment variable for --provider MIN_PROVIDER, and the PR adds MINIMAL_PROVIDER. No MIN_* variable exists in the tree yet, but this is the first variable from that design table to ship, and it is a new public name. Rename it before merge, so that no alias is necessary later. C2: the PR ships and starts the proxy on Linux, but every live BEP e2e case stays NOT RUN on Linux. The reason changed from "runs on macOS only" to "macOS lanes only", and no issue owns the gap (rule 4, rule 6). File the issue and name it in the reason and the PR body.

Precedent: no prior ruling in the ledger covers the provider default, the provider variable, or the BEP on Linux. This ruling sets none aside.

Not ruled: the edit to .github/workflows/release.yml is outside the design. AGENTS.md makes that directory frozen and CODEOWNER-gated, so a code owner must approve it. The design default inside a box is local-box (line 395). The client has no nested routing yet, and no box exposes /dev/kvm, so this PR does not change that path. I did not check by a build that the Linux bep binary links statically for musl. release.yml carries no link gate for it, unlike minzoned.

Conditions

  • C1: Rename the variable from MINIMAL_PROVIDER to MIN_PROVIDER, the name the design gives for --provider. crates/minimal/src/cmd/hosts.rs PROVIDER_ENV becomes "MIN_PROVIDER". Update the doc comments in hosts.rs (resolve_default_provider, default_provider_over, default_provider_tests), crates/minimal/src/cli.rs (GlobalArgs::provider help and Provider), crates/minimal/src/cmd/mod.rs run() and crates/client-config/src/config.rs Config::provider to match. Change the pinned refusal text in default_provider_tests::unknown_provider_values_are_refused and in an_unknown_minimal_provider_refuses_flagless_commands_only (crates/minimal/tests/cli.rs) to MIN_PROVIDER=<value> names no provider. Set MIN_PROVIDER to local or local-minvmd, or unset it. Set MIN_PROVIDER in place of MINIMAL_PROVIDER in crates/minimal/tests/cli.rs, crates/minimal/tests/git_remote.rs, crates/minimal/tests/otel_cli.rs and scripts/session-e2e.sh (the comment and export MINIMAL_PROVIDER=local at line 861). Change docs/reference/cli-min.md lines 40, 47 and 66 and docs/specs/31-spec-box-provider/existing-provider-surface.md line 18 to say MIN_PROVIDER. Accept no MINIMAL_PROVIDER alias: the name is new in this PR, so no user depends on it.
  • C2: scripts/session-e2e.sh bep_live_gate() line 14043 records every live Box Egress Proxy case as NOT RUN on Linux, but this PR makes minvmd start bep serve on Linux and ships it there. File an issue in gominimal/minimal for the Linux live Box Egress Proxy legs (a Linux VM lane with bep beside minvmd, and the TPM or Secret Service key store). Put that issue's number in the Linux not_run reason at line 14043, for example the live Box Egress Proxy cases do not run on Linux lanes yet (#<n>). Name the same issue as a residual in the PR body.

Ruled at 2f598b3 agains 224D t gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1494, job 573983a2-5140-4838-a2cb-8e0d28d05fa4.

0