8000 fix(minimal): min box spec <entry> runs the start's check for every entry · gominimal/minimal@902052e · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): min box spec <entry> runs the start's check for every e…

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. Ruling on #3622 at 902052e9, on arch 8b824707. The ledger already holds a PASS on this same head and arch, and it closed C1 of the CONDITIONS ruling at 5e59eece. No since.diff, since-conditions.json, findings.json or arch-map.md is staged. The why of both earlier rulings is cut short, so I read pr.diff whole and ruled on the full change again. The task marker (D2445, origin bug, fixes #3586) has no covers: line, so the requirement is the task. I split it into the entry form and the project form, as the baseline did.

Governs. architecture.md line 476 (### min box): min box spec <entry> renders the expanded spec and validates, with exit 3 on invalid. Line 490: it shows what an entry will get before anything runs. Line 1253 (## minimal.toml layout): it takes the same flags, so its render is exactly what the host receives.

Ruling. Before this change, the preview checked grants with egress = None and kept only four refusal kinds. So it passed specs that the start refuses, and that breaks lines 476 and 1253. Now render calls boxes::core::bep::check_activation and check_store_references with no filter, in the start's order. The network and the egress come from the start's own helpers in cmd/boxes/create.rs. Only session_effective_egress changes visibility, to pub(crate). Nothing is duplicated. The check stays in its owner (boxes::core::bep), and the preview stays in the client (rule 8). The preview now refuses more, not less, so it fails closed (rule 7). The two new tests run the start's own steps and compare the refusal text and exit code, so they prove the rule rather than relax it (rule 3). The tests.rs edits move two row tests from own_ip with no egress to host_ip, because the start refuses the old fixture under BEP-008. This edit follows the rule and does not relax it. The interim comment that named #2445 is removed, because the full set now runs.

Not decided here. The project form still reads grants from the parsed session field, and the start reads them through project_bep_and_grants. That code predates this PR. The design names only min box spec <entry> and <box|self> (lines 476 and 477), so the no-argument form is outside what it states. The PR body note on it is cut short, and I did not find a linked issue for it.

Not checked. I did not compile or run the tests, per these instructions. The PR body reports min task run agent-verify exit 100 on otel_cli exec_run_attach_and_task_run_share_the_commands_trace, a test outside these files. The PR is a draft because crates/minimal/src/tests.rs is outside the task's layers. That is a plan matter, not a design deviation.

Ruled at 902052e against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1468, job 699e04e1-3283-4991-8056-3bb42d066795.

0