8000 docs(minimald): note the hooks-host attach gap on record_started · gominimal/minimal@da93888 · GitHub
[go: up one dir, main page]

Skip to content

docs(minimald): note the hooks-host attach gap on record_started

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. Re-review of #3568 at da938883. since.diff starts at d8c233cd, and since-conditions.json carries C1. No findings.json is staged. The arch checkout 327e1b57 has no arch-map.md, so I found the sections by search, as the earlier rulings did. Most of since.diff is a merge from main (#3405, #3567, #3557, #3559, #3591). The only PR edit since d8c233cd is commit da938883, a doc comment on BoxActor::record_started that names issue #3604. I checked that pr.diff equals git diff e7844f84..da938883, and I read it whole.

Governs. architecture.md, Output conventions (line 382): started is a box event type. The box record and its states (line 500): running means that the entrypoint started.

Conditions. C1: met, by its residual branch. The task marker D3426 lists only box_actor.rs, box_actor/host.rs and box_actor/tests.rs, so the task must not touch attach.rs. The PR body now has a Residuals heading that names #3604 for the hooks-host attach gap, and the unfiled "Known gap" line is gone. The code comment on record_started names the same issue.

Ruling. Each launch that starts the entrypoint on a new host now writes started through one helper: exec (host.rs line 1765), interactive attach (host.rs line 1989), restart, and finish_resume after resumed. The resume_in_flight flag keeps the attach launch during a resume from writing a second started. The one path left is filed and named, as rule 6 requires. BOX-040 conforms, and nothing is open. No precedent from another PR applies, and none is departed from.

Not checked. I did not confirm that issue #3604 exists, because no gh is available in the sandbox. I did not run the four named tests, because a build is out of bounds. The PR reports them at exit 0. The PR body says that agent-verify timed out on env::tests::minenv_run_forwards_stdin_to_the_task, a test outside this change.

Ruled at da93888 against gominimal/arch@327e1b57d16b by claude-opus-5-5; arch_rulings 1417, job 8ad0cd80-6b87-4629-abd8-7653c00f6bb0.

0