8000 fix(minimal): show GitHub's error when it refuses a sign-in request · gominimal/minimal@98daece · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): show GitHub's error when it refuses a sign-in request

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. This is the first ruling on #3608 at 98daeced, on arch 327e1b57. No since.diff, since-conditions.json or findings.json is staged. The arch checkout has no arch-map.md, so I found the sections by search. The task marker (D3576) has no covers: line, so the requirement is the task itself. No ruling in prior-rulings.json is about the text of a refused GitHub sign-in request, so no precedent applies and none is departed from.

Governs. architecture.md line 337 (principle 7: secrets redacted from all output). gatehouse-spec.md §6.10 line 839 (on an un-enrolled host the client runs the device or browser flow against GitHub directly). architecture.md line 552–554 (min auth login [--device]). The design does not say what a refused device-code request prints. It only requires that no secret reaches the output.

Ruling. post_form now hands a non-success reply to refusal(). That function parses error and error_description with a lenient deserializer, zeroizes the full text, and builds the message from those two fields alone. Both callers keep their placement in crates/minimal/src/cmd/auth.rs. The device-code call passes min auth login --device as the retry command. The browser exchange passes None, because its caller already names min auth login. OAuth error fields carry no credential, and the poll and exchange paths already print them, so the change adds no new kind of output. It conforms.

Not checked. I did not compile or run the tests, per the contract. The PR's agent-verify run failed in minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace. That test is about trace spans, outside cmd/auth.rs, and is not a design question for this change. The PR stays a draft until that check is green or explained.

Ruled at 98daece against gominimal/arch@327e1b57d16b by claude-opus-5-5; arch_rulings 1414, job a9087907-82c7-41c7-8c9d-71be75d6973b.

0