8000 Merge remote-tracking branch 'origin/main' into agent/2376-move-the-exec-and-rpc-crate-tests-into-their-own · gominimal/minimal@83a1628 · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into agent/2376-move-the-e…

Minimal Arch / arch-review succeeded Oct 20, 2026 in 0s

PASS (the design is silent)

Baseline. This is a re-review of 83a16281 against the PASS by absence on abf74374 (this PR). I confirmed that since.diff equals git diff abf74374 83a16281, and pr.diff equals git diff dcefe365 83a16281. The compare has two merges of main (#2453, #2336, #2330, #2455, #2454, #2362) and one PR commit, < 34C6 code class="notranslate">b593055b. The merges do not touch the five PR files. b593055b touches three of them:

  • crates/minimald/src/exec/tests.rs: eight crate::traced::spawn calls go back to tokio::spawn. The base's inline mod tests in exec.rs (at dcefe365) has the same eight tokio::spawn( calls. The move is now a pure move.
  • crates/minimald/src/exec.rs: the #[expect(clippy::disallowed_methods, ...)] attribute goes back onto #[cfg(test)] mod tests;, with the same reason text as the base's inline module.
  • crates/minimald/src/traced.rs: the no_direct_tokio_spawn_blocking scan now skips any file named tests.rs, in addition to traced.rs.

Rule 3 check on the scan change. The scan already skips inline #[cfg(test)] modules through outside_test_modules. I opened every tests.rs under crates/minimald/src: exec/tests.rs, box_runtime/tests.rs, box_manager/tests.rs and box_actor/tests.rs. Each one is declared under #[cfg(test)] in its parent (exec.rs:2873, box_runtime.rs:1566, box_manager.rs:1590, box_actor.rs:1472). So the skip has the same scope as the existing inline skip, and it does not relax the gate for request-handling code. The crate's clippy disallowed-methods ban still applies to these files: the restored expect on mod tests; shows that. A future non-test file named tests.rs will escape the text scan but not the clippy ban.

Governs: nothing. This is a PASS by absence (rubric rule 1). The checkout at 109541a4 has no arch-map.md. I searched architecture.md and specs/ for traced, tokio::spawn, spawn_blocking, disallowed, mod tests, tests.rs and span propagation through spawned tasks. The only spawn_blocking line is in the Gatehouse spec (KMS signing), and it does not apply to minimald. The ruling follows #2454 and #2455. It does not depart from precedent.

Not checked: that the moved tests compile and pass at this head. That needs a build, which is out of bounds. CI is the gate. The PR body reports a local clippy failure in crates/minimald-rpc/src/trace.rs:199 under rustc 1.98.1. That file is not in the diff, and the repository pins 1.97.0.

Ruled at 83a1628 against gominimal/arch@109541a48c31 by claude-opus-5-5; arch_rulings 110, job 2edabb42-2ca7-4c9e-b6ed-df5d58463add.

0