8000 feat(minimal): add min add --session for parity by twitchyliquid64 · Pull Request #963 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

feat(minimal): add min add --session for parity - #963

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/disconnect-shutdown-msg
Jul 25, 2026
Merged

feat(minimal): add min add --session for parity#963
twitchyliquid64 merged 1 commit into
mainfrom
tom/disconnect-shutdown-msg

Conversation

@twitchyliquid64
@twitchyliquid64 twitchyliquid64 commented Jul 25, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Contributor

We have min add --session in the session shell, this adds parity when configuring a local minimal.toml

Note

Add --session flag to cmd_add in the minimal CLI for parity

Adds a new --session long flag to the AddKind mutually exclusive group in lib.rs. When provided, cmd_add calls ctx.add_deps with mctx::AddDepMode::SessionPackages using the graph's top-level packages.

Macroscope summarized a10a28a.

Summary by CodeRabbit

  • New Features
    • Added a --session option to min add.
    • Packages can now be added directly to the current session’s package set.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) July 25, 2026 00:50
@coderabbitai
coderabbitai Bot commented Jul 25, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

min add gains a --session selector for adding packages directly to a session package set. The command dispatches this option through mctx::AddDepMode::SessionPackages.

Changes

Session package additions

Layer / File(s) Summary
Session selector and command routing
crates/minimal/src/lib.rs		 AddKind exposes the mutually exclusive --session flag, and cmd_add routes it to mctx::AddDepMode::SessionPackages.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: 0chroma

Poem

I’m a bunny with packages piled,
A session path now runs compiled.
With one little flag, hops the load,
Through the freshly chosen code road.
Carrots for tests, and joy in the mode!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a summary, but it is missing the required Testing and Checklist sections from the template. Add a Testing section with the commands or manual steps run, and include the Checklist items, plus any linked issue references if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding min add --session support.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 merged commit d899705 into main Jul 25, 2026
29 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/disconnect-shutdown-msg branch July 25, 2026 01:01
This was referenced Jul 29, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @norrietaylor
0