Repository navigation
fix(minimald): return the served contract from the diag bundle handler - #918
Merged
Merged
Conversation
PR #895 changed the serve! dispatch so every handler returns Result<(), ConnectionError> for outcome logging; PR #878 merged alongside it with serve_stream_diag_bundle still returning (). The two were each green against a main that lacked the other, and the type mismatch only surfaced on branches built after both landed. Failure still relays the message over the channel's extended-data stream before surfacing as ConnectionError::Internal, mirroring serve_stream_workspace_files. Refs: #878, #895 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthrough
ChangesDiagnostic bundle error propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
norrietaylor
enabled auto-merge (squash)
July 22, 2026 18:37
twitchyliquid64
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is broken: #895 changed the
serve!dispatch so every handler returnsResult<(), ConnectionError>for outcome logging, and #878 merged 15 minutes later withserve_stream_diag_bundlestill returning(). Each was green against a main that lacked the other; the E0271 type error only surfaces on branches built after both landed (first seen on #916, also failing #880).The handler now returns the outcome, mirroring
serve_stream_workspace_files: failure still relays the message over the channel's extended-data stream, then surfaces asConnectionError::Internalso dispatch logging records it.Verified via cross (aarch64-linux):
clippy --all-targets -- -D warningsclean,minimald --lib164/164 passed.🤖 Generated with Claude Code
Note
Fix
serve_stream_diag_bundleto return the served contract resultUpdates
serve_stream_diag_bundleto returnResult<(), ConnectionError>instead of(). On failure, the error message is sent over the channel's extended-data stream before returningErr(ConnectionError::Internal(msg)); on success it returnsOk(()).Macroscope summarized 8b36c3a.
Summary by CodeRabbit