8000 fix(release): configure linker via env vars to avoid polluting worktree by twitchyliquid64 · Pull Request #766 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

fix(release): configure linker via env vars to avoid polluting worktree - #766

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/release
Jul 15, 2026
Merged

fix(release): configure linker via env vars to avoid polluting worktree#766
twitchyliquid64 merged 1 commit into
mainfrom
tom/release

Conversation

@twitchyliquid64
@twitchyliquid64 twitchyliquid64 commented Jul 15, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Contributor

Should fix the warnings about building from an unclean checkout

Summary by CodeRabbit

  • Bug Fixes
    • Improved Linux release builds for musl-based environments by configuring the linker directly within the build workflow.
    • Removed workflow steps that modified project configuration files during builds, improving build reliability and consistency.

@coderabbitai
coderabbitai Bot commented Jul 15, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow now configures musl-gcc through job-level Cargo linker environment variables for Linux amd64 and arm64 builds, removing steps that modified .cargo/config.toml.

Changes

Musl linker workflow

Layer / File(s) Summary
Job-level linker configuration
.github/workflows/release.yml		 The amd64 and arm64 release jobs define target-specific CARGO_TARGET_<TRIPLE>_LINKER variables and no longer append linker settings to .cargo/config.toml.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: norrietaylor

Poem

I’m a rabbit hopping through the build,
Where musl’s linker path is neatly sealed.
No config edits left behind,
Just job-level env vars aligned.
Cross-compiled artifacts spring forth—
With fluffy paws, from south to north!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the core change: switching release linker configuration to environment variables to keep the worktree clean.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot reviewed Jul 15, 2026
View reviewed changes
@coderabbitai coderabbitai Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Around line 90-96: Remove the added
CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_LINKER entry from the release workflow’s
job-level env block. Keep .github/workflows/release.yml unchanged unless this is
explicitly approved as a CI-maintenance change; relocate the linker
configuration to an allowed non-workflow configuration path instead.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ee0d7db-c096-4ca4-9071-6c1e86c54319

📥 Commits

Reviewing files that changed from the base of the PR and between 81ff76c and 6fad0b5.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Comment thread .github/workflows/release.yml Resolved
@twitchyliquid64
twitchyliquid64 merged commit 091d736 into main Jul 15, 2026
27 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/release branch July 15, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@norrietaylor norrietaylor norrietaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @norrietaylor
0