8000 fix(ci): run the path filter only on pull_request events by norrietaylor · Pull Request #706 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content
8000

fix(ci): run the path filter only on pull_request events #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norrietaylor merged 1 commit into from
Jul 10, 2026
Merged

fix(ci): run the path filter only on pull_request events #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/ci-linux-kvm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ jobs:
persist-credentials: false
- name: Detect relevant changes
id: filter
# v3.0.2, SHA-pinned. On workflow_dispatch there is no diff to filter;
# the downstream `if` treats dispatch as "run everything".
# v3.0.2, SHA-pinned. Runs ONLY on pull_request, where dorny reads
# the PR file list via the API. On push it would need a local diff
# against event.before, which our shallow, credential-free checkout
# (persist-credentials: false) cannot provide — and pushes to main
# SHOULD run everything anyway: they write the main-only caches and
# provide the soak signal. Dispatch likewise runs everything.
if: github.event_name == 'pull_request'
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
with:
filters: |
Expand All @@ -76,7 +81,7 @@ jobs:
# artifact, so a flaky e2e rerun replays only the ~15-minute test job
# instead of this full build. No /dev/kvm needed here.
needs: [changes]
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.kvm == 'true'
if: github.event_name != 'pull_request' || needs.changes.outputs.kvm == 'true'
runs-on: ubuntu-latest
timeout-minutes: 45
env:
Expand Down Expand Up @@ -204,7 +209,7 @@ jobs:
# standalone cargo-nextest binary. A flake rerun of this job alone costs
# ~15 minutes instead of the old 60-minute build+test monolith.
needs: [changes, build-linux]
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.kvm == 'true'
if: github.event_name != 'pull_request' || needs.changes.outputs.kvm == 'true'
runs-on: ubuntu-latest # x86_64; KVM-capable
timeout-minutes: 30
steps:
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/ci-linux-native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@ jobs:
persist-credentials: false
- name: Detect relevant changes
id: filter
# v3.0.2, SHA-pinned. On workflow_dispatch there is no diff to filter;
# the downstream `if` treats dispatch as "run everything".
# v3.0.2, SHA-pinned. Runs ONLY on pull_request, where dorny reads
# the PR file list via the API. On push it would need a local diff
# against event.before, which our shallow, credential-free checkout
# (persist-credentials: false) cannot provide — and pushes to main
# SHOULD run everything anyway: they write the main-only caches and
# provide the soak signal. Dispatch likewise runs everything.
if: github.event_name == 'pull_request'
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
with:
filters: |
Expand Down Expand Up @@ -79,7 +84,7 @@ jobs:
# ran (crates/minimald/tests/netns.rs, mesh_uc7.rs). The code and tests
# stay in-tree and runnable locally; they are just not CI-covered.
needs: [changes]
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.native == 'true'
if: github.event_name != 'pull_request' || needs.changes.outputs.native == 'true'
runs-on: ubuntu-latest
timeout-minutes: 40
steps:
Expand All @@ -98,7 +103,7 @@ jobs:
# ran the daemon natively at all. The native target needs no E2E_* knobs:
# host daemon, repo as the project.
needs: [changes]
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.native == 'true'
if: github.event_name != 'pull_request' || needs.changes.outputs.native == 'true'
runs-on: ubuntu-latest
timeout-minutes: 40
steps:
Expand Down
Loading
0