Repository navigation
fix(minimald::rpc::CreateSession): communicate an error if the session name is not unique - #381
Merged
Merged
Conversation
…n name is not unique
Contributor
📝 WalkthroughWalkthroughThis PR introduces an ChangesRPC Error Response Wrapper
Sessions Actor Error Type Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/minimald/src/rpc.rs (1)
67-103: Drop the redundantDebug + PartialEqbounds fromErrorable<S>
Errorableis declared aspub enum Errorable<S: std::fmt::Debug + PartialEq>, but its methods (unwrap/ok/err) and itsFrom<Result<T, E>>impl don’t rely onDebug/PartialEq. SinceErrorablealready derivesDebug,PartialEq, andEq, the required trait bounds are naturally enforced only when those trait impls are used—so the declaration-level bounds unnecessarily restrict everyErrorable<T>.♻️ Proposed fix
-pub enum Errorable<S: std::fmt::Debug + PartialEq> { +pub enum Errorable<S> { Ok(S), Err { error: String }, } -impl<S: std::fmt::Debug + PartialEq> Errorable<S> { +impl<S> Errorable<S> { pub fn unwrap(self) -> S { match self { Self::Ok(s) => s, Errorable::Err { error } => panic!("unwrap of error value: {error}"), } } @@ -impl<T: std::fmt::Debug + PartialEq, E: ToString> From<Result<T, E>> for Errorable<T> { +impl<T, E: ToString> From<Result<T, E>> for Errorable<T> { fn from(value: Result<T, E>) -> Self { match value { Err(e) => Self::Err { error: e.to_string(), }, Ok(t) => Self::Ok(t), } } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/minimald/src/rpc.rs` around lines 67 - 103, The enum declaration imposes unnecessary type bounds: remove "S: std::fmt::Debug + PartialEq" from "pub enum Errorable<S>" so the enum itself is generic over S without those constraints, and adjust the impl blocks accordingly (the inherent impl impl<S> Errorable<S> and the From<Result<T, E>> impl should not require Debug+PartialEq on S; keep the From impl generic as "impl<T, E: ToString> From<Result<T, E>> for Errorable<T>"). Ensure references to Errorable::Ok/Err, unwrap, ok, err, and the From<Result<T, E>> remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/minimald/src/rpc.rs`:
- Around line 67-103: The enum declaration imposes unnecessary type bounds:
remove "S: std::fmt::Debug + PartialEq" from "pub enum Errorable<S>" so the enum
itself is generic over S without those constraints, and adjust the impl blocks
accordingly (the inherent impl impl<S> Errorable<S> and the From<Result<T, E>>
impl should not require Debug+PartialEq on S; keep the From impl generic as
"impl<T, E: ToString> From<Result<T, E>> for Errorable<T>"). Ensure references
to Errorable::Ok/Err, unwrap, ok, err, and the From<Result<T, E>> remain
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e3723a4d-661b-4627-a1c3-e960dba7045b
📒 Files selected for processing (5)
crates/minimald/src/exec.rscrates/minimald/src/rpc.rscrates/minimald/src/session.rscrates/minimald/src/sessions.rscrates/minimald/src/sftp.rs
twitchyliquid64
enabled auto-merge (rebase)
June 11, 2026 19:25
norrietaylor
approved these changes
Jun 12, 2026
This was referenced Jun 15, 2026
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that cheeky no-error-but-didnt-create-a-session we saw during the demo.
Summary by CodeRabbit
Release Notes
Bug Fixes
New Features