Repository navigation
fix(mctx): an in-box min patched-pkg of a task builds in the classifier leaf of its box, or on the - #3708
Conversation
run_patched_pkg now gives op::PatchedBuild the classifier leaf of its context, or the box network when the context has no leaf, as the session channel in minimald does. A context made for no box gives neither, so the build stays the caller's own traffic.
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This change conforms to the networking design. Section 7.1 line 267 says that a hash not in the creator's table builds under the requesting box's own rules. A patched spec is such a hash. run_patched_pkg now gives the build the box's leaf, or the box's network when the box has no leaf. Before, the build ran as the daemon's own traffic. The choice is the same as the minimald session channel. Nobody ran the deny-all runtime proof, and no e2e leg runs min patched-pkg. Note this for the epic's acceptance walk.
Ruled at 9756aaa against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
Follow-up
Fixes #3697
crates/mctx/src/env.rscrates/mctx/src/lib.rsTask marker
Proof
An in-box min patched-pkg build now runs in the classifier leaf of its box, or on the box network when the box has no leaf. So in a deny-all task box, a patched-pkg build that needs a download gets the box's egress rules, as a min install build in the same box does. The unit test shows the choice: leaf, network, or neither for a context made for no box.
Notes from the agent: The choice is in env::patched_build_egress. A leaf wins over a network, which matches crates/minimald/src/env.rs. No end-to-end run in a deny-all box was made on this machine. The unit test proves the wiring, not a refused download. cargo clippy -p mctx --all-targets is clean.
Tests
cargo test -p mctx patched_build_takes_the_leaf_or_the_network_of_its_boxVerify
min task run agent-verifypassed ([tasks.verify]).