8000 fix(installer): purge the cache dir the runtime writes on macOS by bryan-minimal · Pull Request #3538 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(installer): purge the cache dir the runtime writes on macOS - #3538

Merged
bryan-minimal merged 1 commit into
mainfrom
fix/uninstall-purge-cache-dir
Nov 19, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
fix/uninstall-purge-cache-dir

Conversation

@bryan-minimal
Copy link
Copy Markdown
Member

What

--uninstall --purge now removes ~/Library/Caches/minimal on macOS. It used to leave that tree behind.

Fixes gominimal/inbox#1177

Why

The installer resolved the cache as ${XDG_CACHE_HOME:-~/.cache}/minimal. On macOS the runtime takes its cache from the platform cache directory, so the purge looked in a place the runtime never wrote.

How

The purge resolves each tree (data, state, cache) the way the runtime does, as well as the way the installer did:

  • an XDG variable counts only when it is absolute;
  • the macOS cache is ~/Library/Caches/minimal.

One tightening

Only an absolute path that ends in /minimal is purged. A relative XDG value used to resolve against the current directory; it is now ignored.

Testing

scripts/install_test.sh gains a macOS case: a dry run names ~/Library/Caches/minimal, and a real purge removes it and the XDG cache tree. It also drives the absolute-path rule with a relative XDG value.

The installer tests pass under sh, bash and dash. Workspace lint, tests and the native end-to-end script pass on this commit.

🤖 Generated with Claude Code

`--uninstall --purge` removed the data, state and cache trees where the
installer resolves them, `${XDG_CACHE_HOME:-~/.cache}/minimal` for the
cache. On macOS the runtime takes its cache from the platform cache
directory, `~/Library/Caches/minimal`, so the purge left that tree behind.

The purge now also removes each tree where the runtime writes it, through a
resolver that mirrors crates/paths: an XDG variable counts only when it is
absolute, and the macOS cache is `~/Library/Caches/minimal`. Only an
absolute `.../minimal` path is purged, so a relative XDG value no longer
resolves against the current directory.

Fixes gominimal/inbox#1177

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 17:01
@coderabbitai
coderabbitai Bot commented Nov 18, 2026
Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 55221e78-e275-4678-8c1d-d3d732dfaeb3
Commits

Reviewing files that changed from the base of the PR and between ff906b9 and 6689ae2.

Files selected for processing: 2

  • scripts/install.sh
  • scripts/install_test.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 6689ae245b7e.

Nothing to do.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 18, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit b7c2417 Nov 19, 2026
42 checks passed
@bryan-minimal
bryan-minimal deleted the fix/uninstall-purge-cache-dir branch November 19, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0