8000 fix(installer): the pinned install card says which releases report (0.7) by bryan-minimal · Pull Request #3534 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(installer): the pinned install card says which releases report (0.7) - #3534

Merged
norrietaylor merged 3 commits into
release/0.7.xfrom
fix/install-card-pinned-wording-0.7
Nov 19, 2026
Merged

norrietaylor merged 3 commits into
release/0.7.xfrom
fix/install-card-pinned-wording-0.7

Conversation

@bryan-minimal
Copy link
Copy Markdown
Member

What

For a --version install, the card's line about reporting now reads "min 0.7.4 and later report this install once a day".

Refs #3504 (a review note there). The same change is open against main.

Why

The card said min reports the install once a day. A pinned release older than 0.7.4 has no update check and sends nothing. For those installs the card described a request that is never made.

It goes to this line so that the installer that ships with 0.7.4 says the same as the one on main.

Scope

One line of scripts/install.sh.

Testing

The installer tests pass under sh, bash and dash, and the workspace lint, tests and native end-to-end script pass on this commit.

🤖 Generated with Claude Code

For a --version install the card said min reports the install once a day.
A pinned release older than 0.7.4 has no update check and sends nothing, so
the card described a request that is never made. The line now reads
"min 0.7.4 and later report this install once a day".

Refs #3504

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
8000
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 16:57
@coderabbitai
coderabbitai Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 32d0f9a0-9e26-406c-9296-f6cd7408e979

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 38a453d63acc.

Nothing to do.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@norrietaylor
Copy link
Copy Markdown
Member

/revise

@minimal-foundry
minimal-foundry Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Round 1 of 10 changed nothing: The runner already merged origin/release/0.7.x into this branch (merge commit a9083599, which includes #3556 at dcae13c). The directive asked for exactly that update, with no cherry-pick and no change to the PR's diff. I made no further commits. git diff origin/release/0.7.x..HEAD shows only scripts/install.sh. I did not run the installer tests under dash because dash is not installed on this box. I did not run the KVM lane locally.. This pull request is still open.

branch fix/install-card-pinned-wording-0.7

round outcome job
1 changed nothing: The runner already merged origin/release/0.7.x into this branch (merge commit a9083599, which includes #3556 at dcae13c). The directive asked for exactly that update, with no cherry-pick and no chang 2c0796ae

Updated 2026-11-18T21:34:17.821Z.

@minimal-foundry
Copy link
Copy Markdown
Contributor

That /revise is held, not dropped. The container fleet is mid-roll: a new image is deploying, and an instance on the old one refused the coder. Your note is kept and asked again every 10 minutes for up to 30; a wait that outlives that is refused here with the reason.

What the runner said

could not start the coder: Error: runner refused the job: HTTP 400 {"error": "runtime_sha does not match this image", "job_runtime_sha": "9f3632309e2ca333ec87b1af5fae374c932daf48", "image_runtime_sha": "2ab0abc64d8aa968129f50d4b69dd8ae6e13c55b"}

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry
Copy link
Copy Markdown
Contributor

Round 1 of 10 on a /revise note: the coder changed nothing. The runner already merged origin/release/0.7.x into this branch (merge commit a9083599, which includes #3556 at dcae13c). The directive asked for exactly that update, with no cherry-pick and no change to the PR's diff. I made no further commits. git diff origin/release/0.7.x..HEAD shows only scripts/install.sh. I did not run the installer tests under dash because dash is not installed on this box. I did not run the KVM lane locally.

@norrietaylor
norrietaylor merged commit ace8a8d into release/0.7.x Nov 19, 2026
38 of 40 checks passed
@norrietaylor
norrietaylor deleted the fix/install-card-pinned-wording-0.7 branch November 19, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0