8000 docs(specs): pin spec 29 to arch main 327e1b57 by agent-137 · Pull Request #3452 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

docs(specs): pin spec 29 to arch main 327e1b57 - #3452

Merged
agent-137 merged 1 commit into
mainfrom
docs/spec29-arch-pin
Nov 16, 2026
Merged

agent-137 merged 1 commit into
mainfrom
docs/spec29-arch-pin

Conversation

@agent-137
@agent-137 agent-137 commented Nov 15, 2026 •
Copy link
Copy Markdown
Member

Spec 29 (BOX) has been pinned at arch 823f45fa since it was first written in #1697. This PR moves the arch: link and arch_sha to arch main 327e1b57, on Karl's ruling of 2026-11-15.

The new pin includes gominimal/arch#181, the file-exports ruling (gominimal/arch#180) that BOX-185 to BOX-204 follow. These requirements merged in #3376.

The jump also takes in the arch changes from gominimal/arch#125 to gominimal/arch#173: the min box run PTY and attach rules, min box wait --timeout and the start and run flags, [params], networking v0.9.2 to v0.9.4 with build boxes, and exec_enabled. This PR changes no requirement. A gap between spec 29 and those changes is a follow-up issue, not part of this PR.

Only the frontmatter changes: arch, arch_sha and updated. The spec linter reports only P004 findings, which are normal for this spec.

🤖 Generated with Claude Code

https://claude.ai/code/session_016CYvTvep9ZaSf5pJMB2hQA

Summary by CodeRabbit

  • Documentation
    • Updated the local-first specification’s reference information to reflect a newer architecture revision and a more recent update date. No user-facing functionality or public behavior changed.

Spec 29 was pinned at arch 823f45fa, its first version. Move the pin to
arch main 327e1b57, which includes gominimal/arch#181 (file exports
come back with the command that waits for the box; BOX-185 to BOX-204).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CYvTvep9ZaSf5pJMB2hQA
@agent-137
agent-137 requested a review from a team as a code owner November 15, 2026 22:11
@coderabbitai
coderabbitai Bot commented Nov 15, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The spec metadata now references architecture commit 327e1b57d16b31ae1f4249cb317e3bd5b22e98b8 and records an update date of 2026-11-15.

Changes: Spec metadata

Layer / File(s) Summary
Update architecture reference
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md
The architecture reference and SHA now point to commit 327e1b57d16b31ae1f4249cb317e3bd5b22e98b8. The update date changes from 2026-11-13 to 2026-11-15.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • gominimal/minimal#3376: Adds file-export requirements to spec 29, which are included in the architecture commit referenced here.

Suggested reviewers: mitodrummer

Merge Risk: Minimal · up to 3f67a

This is a documentation metadata update that moves the spec's arch pin and date. It has no runtime effect and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title uses Conventional Commit form (docs(specs): ...) and names the main change: pinning spec 29 to arch main commit 327e1b57. The diff updates the arch link, arch_sha and updated date in the spe…
Description check Passed The description covers the purpose (moving the arch pin from 823f45fa to 327e1b57 per Karl's 2026-11-15 ruling), the related arch PRs, the scope limited to frontmatter changes, and linter results. It …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses Conventional Commit form (docs(specs): ...) and names the main change: pinning spec 29 to arch main commit 327e1b57. The diff updates the arch link, arch_sha and updated date in the spec frontmatter, so the title matches the changeset. It is short and specific.

Full details: Description check

Explanation

The description covers the purpose (moving the arch pin from 823f45fa to 327e1b57 per Karl's 2026-11-15 ruling), the related arch PRs, the scope limited to frontmatter changes, and linter results. It does not follow the repository template: the Testing section and the Checklist are missing, and the Summary section has no links in the expected 'Refs: #123' or 'Closes: #123' form. The description also does not state whether docs need updating, though this is a docs-only change. Most required content is present, so the check passes, but the template sections should be added.

Resolution

Add a Testing section with the spec linter output (the P004 result is mentioned in prose but not pasted as evidence). Add the Checklist items, including confirmation that no BREAKING CHANGE footer is needed. Add a Refs line to the related issues or PRs in the Summary section.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Vale (3.24.0)

{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}

A rabbit checks the spec at dawn
The commit and date are freshly drawn
One reference hops to something new
The update date follows through
Then off through clover, ears askew

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: dfdd4587-6c5e-4265-b5b0-49c4d92ab46e
Commits

Reviewing files that changed from the base of the PR and between 000d3ef and 3f67afa.

Files selected for processing: 1

  • docs/specs/29-spec-box-local-first/29-spec-box-local-first.md

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@github-actions
Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/29-spec-box-local-first/29-spec-box-local-first.md — 21 finding(s)

docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:440: P004 BOX-182 names test 'loadout_file_ask_without_terminal_denied', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:555: P004 BOX-185 names test 'waiting_command_copies_file_exports_after_box_ends', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:560: P004 BOX-186 names test 'detached_start_or_stop_copies_no_exports', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:564: P004 BOX-187 names test 'directory_export_copies_its_tree_and_deletes_nothing', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:569: P004 BOX-188 names test 'export_writes_each_file_atomically', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-lo
8000
cal-first.md:574: P004 BOX-189 names test 'export_path_outside_project_refused_exit3', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:579: P004 BOX-190 names test 'missing_export_named_and_others_copied', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:583: P004 BOX-191 names test 'failed_export_file_leaves_its_destination_unchanged', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:588: P004 BOX-192 names test 'export_through_escaping_symlink_writes_nothing', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:593: P004 BOX-193 names test 'skipped_export_exit125_when_task_succeeded', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:597: P004 BOX-194 names test 'skipped_export_keeps_failed_task_exit_code', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:602: P004 BOX-195 names test 'export_report_appends_file_exported_event', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:608: P004 BOX-196 names test 'export_source_symlink_out_of_workbench_writes_nothing', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:614: P004 BOX-197 names test 'skipped_export_leaves_record_exit_code', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:619: P004 BOX-198 names test 'export_claim_granted_once_for_each_end', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:624: P004 BOX-199 names test 'exports_not_copied_from_another_project', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:629: P004 BOX-200 names test 'lost_export_report_named_exit_unchanged', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:635: P004 BOX-201 names test 'refused_export_claim_copies_nothing', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:641: P004 BOX-202 names test 'export_claim_released_for_unreported_exports_on_disconnect', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:647: P004 BOX-203 names test 'multi_box_wait_copies_in_order_of_ends', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:652: P004 BOX-204 names test 'resumed_box_copies_at_next_end_only', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@5ffd41cf, spec format: How Minimal Writes Specs.

@minimal-foundry
minimal-foundry Bot commented Nov 15, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 3f67afa8542e.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 15, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 15, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 4564240 Nov 16, 2026
41 checks passed
@agent-137
agent-137 deleted the docs/spec29-arch-pin branch November 16, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0