Repository navigation
fix(minimal): every rename of a running host_ip box moves only its name hold and keeps its VM-host - #3395
Conversation
The dashboard rename moved the name holds itself and did not withdraw the old name by the box's id. It now calls rename_box_with_vm_host, the move that min session rename and min box rename make. A test pins that this move sends no retire to the VM host daemon.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none seen. |
There was a problem hiding this comment.
Reviewed against D3011 at 4aafcbc7. dash::rpc::rename now calls crate::rename_box_with_vm_host, the path min box rename and min session rename already take, so a running host_ip box's old name is withdrawn by its id, its hold moves, and nothing is retired: the box keeps its egress rules. dashboard_rename_of_host_ip_box_retires_nothing asserts withdraw, release and hold and no retire. It drives the shared helper rather than dash::rpc::rename, as the plan places it. Arch: PASS against arch 15b603e6, no conditions.
Defect
Fixes #3384
crates/minimal/src/dash/rpc.rscrates/minimal/src/cmd/boxes/vm_host.rsTask marker
Proof
min box rename, min session rename and the dashboard rename of a running host_ip box now all go through rename_box_with_vm_host. The VM host daemon gets a withdraw of the old name by the box's id, a release of the old name and a hold of the new name. It gets no retire request, so the box keeps its egress rules.
Notes from the agent: move_held_box_name already sent no retire at the branch head, so vm_host.rs gets only the new test. The new test calls rename_box_with_vm_host over control_sock_beside(ssh socket), which is the exact call dash::rpc::rename now makes. It does not drive dash::rpc::rename itself, because that needs a live daemon client. cargo clippy -p minimal --all-targets is clean.
Tests
cargo test -p minimal a_rename_retires_nothing_and_a_stop_retires_as_stoppedcargo test -p minimal dashboard_rename_of_host_ip_box_retires_nothingVerify
min task run agent-verifyexited 100, so this PR is a draft.