Repository navigation
fix(minimal): a dashboard destroy and the prepare_attach undo retire a host_ip box with retries, and - #3361
Conversation
The dashboard's destroy and the undo of its attach re-admit sent the host_ip retire once, so a lost exchange left a gone box's rules in the gate's union. Both now retire through retire_host_ip_box_with_vm_host, as min session destroy and attach do. A re-admit of a live session logs the admitted info line.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
/revise make Evidence: the PR body's verify section says one of 1101 tests failed ("1101 tests run: 1100 passed, 1 failed, 2 skipped", "Cancelling due to test failure"). The tail is cut off before the failing test's name. Both of this task's own Do:
|
|
Round 1 of 10 on a /revise note: the coder changed nothing. I did not reproduce the verify failure. I ran the gate's test step (cargo nextest run --locked -p minimal) five times at 1fdb663 in a worktree, and once at the current head 14d50502 (1fdb663 merged with origin/main). Every run passed: 1101/1101 at 1fdb663 and 1115/1115 at 14d50502. The directive's evidence cuts off before the test name, so I cannot name the test that failed. The two new tests use no sleeps or wall-clock waits. The retire retry has a 100 ms backoff inside a BOX_CONTROL_TIMEOUT deadline, and the fake daemon answers at once. I conclude that the failure was a timing flake elsewhere in the minimal crate's suite, and not a failure that this change causes. I changed no file. I did not run fmt, clippy or the quality gate parts of agent-verify. The PR body reports only a test failure. |
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The change conforms to UC5 (line 107) and §5.5 (line 184). A dashboard destroy and the prepare_attach undo now retire a host_ip box through crate::retire_host_ip_box_with_vm_host, which retries. Thus one lost exchange does not leave a gone box's rules in the gate's union. The dashboard path now matches min session attach and min session destroy, as the #3368 ruling requires. The new info line goes to dash.log, not to the terminal. The failed verify test is in otel_cli.rs and does not reach this code. The merge gate must settle it.
Ruled at 1fdb663 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
Reviewed at 1fdb6630496c against D2989's plan block. settle_destroyed_box and the prepare_attach undo now call retire_host_ip_box_with_vm_host, the retrying path min session destroy uses, so one lost exchange no longer leaves a gone box's rules in the gate's union (NET-085). A lookup error in the undo still does nothing, as before, and a live session logs the admitted line, as the block asks. Both tests use a stand-in daemon that drops the first retire's connection, and both assert a second retire arrives. The only file changed is the one layer the task names.
Defect
Fixes #3352
crates/minimal/src/dash/rpc.rsTask marker
Proof
When the first retire exchange of a dashboard destroy, or of the dashboard attach's undo for a gone box, fails, the VM host daemon gets a second retire. The two new tests in crates/ 8000 minimal/src/dash/rpc.rs show this with a stand-in daemon that drops the first retire and counts two.
Notes from the agent: settle_destroyed_box and the prepare_attach undo now call crate::retire_host_ip_box_with_vm_host. A re-admit that finds the session still live logs the same info line as min session attach. No test pins that log line, because the crate has no log-capture helper and no test line asks for one. The dash::rpc tests (16) pass and cargo clippy -p minimal --all-targets is clean. The test module has its own copy of the stand-in fake_vm_host_dropping_retires, because the copy in cmd/boxes/vm_host.rs is private to that test module and outside the layers.
Tests
cargo test -p minimal tui_destroy_retires_a_host_ip_box_after_a_lost_exchangecargo test -p minimal dashboard_attach_retires_a_gone_host_ip_box_after_a_lost_exchangeVerify
min task run agent-verifyexited 100, so this PR is a draft.