FFFF T26 — Retained boxes managed, end to end by minimal-foundry[bot] · Pull Request #3273 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T26 — Retained boxes managed, end to end - #3273

Merged
mitodrummer merged 1 commit into
mainfrom
agent/2920-retained-boxes-managed-end-to-end
Nov 11, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
agent/2920-retained-boxes-managed-end-to-end

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

T26 — Retained boxes managed, end to end

slice: S6
kind: integration
covers: none
size: S
est: 20 code, 100 tests
executor: agent
difficulty: routine
model: light
diagnostics: when the end-to-end test fails, it prints each command it ran with that command's stdout, stderr and exit code
observability: one span covers the rename, the copy, the events read and the prune of the same box
layers:
- tests:
- crates/minimal/src/tests.rs: the slice's end-to-end test over a test daemon
test: cargo nextest run -p minimal retained_box_management_end_to_end
produces: none
consumes: none
proof: Rename a box, prune old boxes with a dry run that shows the disk they hold, copy a file out of a stopped box, replay or follow a box's events, and restart a long-running box.
depends on:
- blocked by #2907
- blocked by #2915
- blocked by #2908
- blocked by #2909

Proof

In one test over a harness daemon, a person can see a box renamed from web to front, a file copied out of it after it stops, its events replayed and followed, and a prune dry run that lists it with the disk it holds and removes nothing. Then a prune removes it and the follow ends. A long-running box restarts under the same id and name. A failure prints each command run so far, with its stdout, stderr and exit code.

Notes from the agent: The harness daemon cannot start a box, so the restart answer is scripted through cmd::restart_box_on_hosts_with, the same as box_restart_until_stopped_restarts_same_id_and_name. The test asserts that the box rename, box cp and box events events are logged in the retained_box_end_to_end span with the box id. The prune runs inside the span too, but nothing in the log proves it: prune_hosts logs no client event on success, because cmd_box_prune logs the verb after prune_hosts returns. The daemon-side RPC parent_span_id does not help either, because it is the same inside and outside the span. If the observability line needs a logged prune event in the span, prune_hosts in crates/minimal/src/cmd/boxes/lifecycle.rs needs a tracing event, and that file is outside this task's layers.

Tests

line exit tail
cargo nextest run -p minimal retained_box_management_end_to_end 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.

Verify

min task run agent-verify exited 100 under rustc 1.99.0, w 8000 hich the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "07aeb76d4e9a26f3",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "8ed3079a717e6ad9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "8ed3079a717e6ad9",
                "queued_behind": "0",
                "span_id": "d468bd93830db27c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "07aeb76d4e9a26f3",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "745e3bb3647ced49",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "745e3bb3647ced49",
                "queued_behind": "0",
                "span_id": "3034b27df0c5edb9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "745e3bb3647ced49",
                "queued_behind": "0",
                "span_id": "d672a88b9ca413e4",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "d672a88b9ca413e4",
                "span_id": "8d46361605bcd390",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "d672a88b9ca413e4",
                "queued_behind": "0",
                "span_id": "6d410479517e6eaf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  58.598s] 1062 tests run: 1061 passed, 1 failed, 1 skipped
        FAIL [   2.891s] (1062/1062) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Closes #2920

One test renames a box, copies a file out of it after it stops,
replays and follows its events, lists it in a prune dry run with the
disk it holds, and prunes it, which ends the follow. It also restarts
a long-running box under the same id and name. A failure prints each
command it ran with its output and exit code.
@minimal-foundry
minimal-foundry Bot requested a review from a team as a code owner November 11, 2026 06:14
@coderabbitai
coderabbitai Bot commented Nov 11, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5dff12b-f0b6-4c40-8244-d0b8734b29f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 11, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 212e2816f8de.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none: the diff only appends.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The test conforms to the design. The rename keeps the box id (line 487). The copy reads from the stopped box, and the events replay and follow (line 502). The dry run lists only the stopped box with its disk (line 502). The restart keeps the id and name (line 471). The test does not prove a prune event in the span, as the PR body says. The design does not require that span, so it is not a condition here.

Ruled at 212e281 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 11, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit f4048c0 Nov 11, 2026
38 checks passed
@mitodrummer
mitodrummer deleted the agent/2920-retained-boxes-managed-end-to-end branch November 11, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T26 — Retained boxes managed, end to end

1 participant

0