8000 test(minimal): keep the answerer sibling test off the host's real port by bryan-minimal · Pull Request #3264 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

test(minimal): keep the answerer sibling test off the host's real port - #3264

Closed
bryan-minimal wants to merge 1 commit into
mainfrom
test/1232-answerer-sibling-port
Closed

bryan-minimal wants to merge 1 commit into
mainfrom
test/1232-answerer-sibling-port

Conversation

@bryan-minimal
Copy link
Copy Markdown
Member

Fixes gominimal/inbox#1232.

What

the_answerer_facts_ride_beside_a_down_proxy_sibling (crates/minimal/src/resolver.rs) named the holder at 7656, the answerer's real port, and then read the liveness query's answer. On a machine whose own daemon answers there, the query is answered, the read says bound instead of holder, and the test fails. It happened twice in ten minutes on a host running two test suites beside a live daemon.

The holder is now a port the test binds on loopback and never answers on. The silent socket stays bound for the whole test, so nothing else can take the port meanwhile, and the expected answerer line names that port.

Why test-only

The read is right: a port something answers on is bound. The test's assumption, that nothing on the host answers at 7656, is what was wrong, and it holds for no developer who has min installed.

Tests

  • The test now passes beside a running daemon, which it did not before.
  • Unit tests for the minimal crate, run repeatedly in parallel with the daemon on the host, pass; the baseline scenario passes on both sides of the change.

🤖 Generated with Claude Code

the_answerer_facts_ride_beside_a_down_proxy_sibling named the holder at
7656, the answerer's real port, and read the liveness query's answer:
on a machine whose own daemon serves there the query is answered, the
read says bound, and the test fails (gominimal/inbox#1232; twice in ten
minutes on a lab box running two pre-pushes). The holder is now a port
the test binds on loopback and never answers on, held for the whole
test so nothing else can take it, and the expected line names it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai
coderabbitai Bot commented Nov 10, 2026
Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@bryan-minimal
Copy link
Copy Markdown
Member Author

Superseded: #3166 (merged today, after this branch was cut) keeps this test off the host's real port by driving the liveness probe through a seam, so no datagram is sent at all. CI's merge of this branch with main combines the two and fails on main's assertion. Closing; gominimal/inbox#1232 is fixed by #3166.

@bryan-minimal
bryan-minimal deleted the test/1232-answerer-sibling-port branch November 11, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0