Repository navigation
test(minimal): keep the answerer sibling test off the host's real port - #3264
Closed
bryan-minimal wants to merge 1 commit into
Closed
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
the_answerer_facts_ride_beside_a_down_proxy_sibling named the holder at 7656, the answerer's real port, and read the liveness query's answer: on a machine whose own daemon serves there the query is answered, the read says bound, and the test fails (gominimal/inbox#1232; twice in ten minutes on a lab box running two pre-pushes). The holder is now a port the test binds on loopback and never answers on, held for the whole test so nothing else can take it, and the expected line names it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Member
Author
|
Superseded: #3166 (merged today, after this branch was cut) keeps this test off the host's real port by driving the liveness probe through a seam, so no datagram is sent at all. CI's merge of this branch with main combines the two and fails on main's assertion. Closing; gominimal/inbox#1232 is fixed by #3166. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gominimal/inbox#1232.
What
the_answerer_facts_ride_beside_a_down_proxy_sibling(crates/minimal/src/resolver.rs) named the holder at 7656, the answerer's real port, and then read the liveness query's answer. On a machine whose own daemon answers there, the query is answered, the read says bound instead of holder, and the test fails. It happened twice in ten minutes on a host running two test suites beside a live daemon.The holder is now a port the test binds on loopback and never answers on. The silent socket stays bound for the whole test, so nothing else can take the port meanwhile, and the expected answerer line names that port.
Why test-only
The read is right: a port something answers on is bound. The test's assumption, that nothing on the host answers at 7656, is what was wrong, and it holds for no developer who has
mininstalled.Tests
minimalcrate, run repeatedly in parallel with the daemon on the host, pass; the baseline scenario passes on both sides of the change.🤖 Generated with Claude Code