You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(release): restore the signing group repository after adding a branch - #3088
Adds a step to the release branch procedure in docs/internal/release-pipeline.md: after updating the signing runner group's workflow list, add gominimal/minimal back to the group and check that it is listed.
Why
The documented PATCH can leave the group with no repositories. The group then holds the signing jobs in the queue while its runner stays idle. This happened to a release dry run, and adding the repository back released it.
The cause is likely the PATCH but was not reproduced, to avoid another test write on the live group. The added PUT is safe to repeat, so the step holds either way.
Verification
The PUT and the check are the commands that restored the group: the check printed gominimal/minimal, and the queued job started on the runner about a minute later.
just lint-prose docs/internal/release-pipeline.md.
Summary by CodeRabbit
Documentation
Added guidance for restoring the repository list after updating the signing runner group, and checking that the repository is listed to help prevent signing jobs from remaining queued.
No actionable comments were generated in the recent review.
Walkthrough
The release pipeline instructions now warn that updating the signing runner group can clear its repository list. They add commands to restore gominimal/minimal and verify that it appears in the list.
The instructions explain that an empty repository list can prevent signing jobs from running. They add commands to restore gominimal/minimal and verify the list.
gominimal/minimal#3066: Adds instructions to admit a release branch to the signing runner group.
Suggested reviewers:agent-137
Merge Risk: Minimal · up to 92055
The instructions restore and check the repository’s runner access. No actionable merge risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title identifies the documented change to restore the signing group repository.
Description check
The description ex
8000
plains the change, its cause, and verification. It omits the template's checklist and does not include the lint output.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Vale (3.24.0)
{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}
A rabbit checks the runner’s list, One repo missing, jobs persist. Restore the name, then check once more, The signing jobs can find the door. I hop away; the list is right.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 7a04c385-2033-4989-ae9a-620327fdbbcb
Commits
Reviewing files that changed from the base of the PR and between cd262ac and 9205529.
Files selected for processing: 1
docs/internal/release-pipeline.md
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
The reason will be displayed to describe this comment to others. Learn more.
Approving. The PUT is idempotent and the check prints what it should, so the step is safe either way.
On the cause: the PATCH above resends visibility from the GET. The likely culprit is that a write of visibility: "selected" resets the group's selected-repository list. If so, dropping visibility from the --jq object, so the PATCH sends only restricted_to_workflows and selected_workflows, would stop the list emptying in the first place. That's untested, and I wouldn't test it on the live group either. The restore step is right to keep regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a step to the release branch procedure in
docs/internal/release-pipeline.md: after updating thesigningrunner group's workflow list, addgominimal/minimalback to the group and check that it is listed.Why
The documented
PATCHcan leave the group with no repositories. The group then holds the signing jobs in the queue while its runner stays idle. This happened to a release dry run, and adding the repository back released it.The cause is likely the
PATCHbut was not reproduced, to avoid another test write on the live group. The addedPUTis safe to repeat, so the step holds either way.Verification
PUTand the check are the commands that restored the group: the check printedgominimal/minimal, and the queued job started on the runner about a minute later.just lint-prose docs/internal/release-pipeline.md.Summary by CodeRabbit