Repository navigation
build(deps): bump pageant from 0.2.3 to 0.2.5 - #2824
Conversation
Bumps [pageant](https://github.com/warp-tech/russh) from 0.2.3 to 0.2.5. - [Release notes](https://github.com/warp-tech/russh/releases) - [Commits](https://github.com/warp-tech/russh/commits) --- updated-dependencies: - dependency-name: pageant dependency-version: 0.2.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Reviewed: 1 finding, none blocking at Address the comments on the diff. Clobber: none seen. |
| dependencies = [ | ||
| "libc", | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
LOW · correctness · confidence 0.50
This bump also moves several unrelated crates (socket2-style users, rustix, quinn-udp, tempfile, rustls-platform-verifier, iana-time-zone) from windows-sys 0.61.2 to 0.52.0, and one crate from windows-core 0.62.2 to 0.61.2. A pageant bump does not need this. It is a downgrade that adds an older copy of the Windows crates to Windows builds. Check whether pageant 0.2.5 requires it. If not, regenerate the lock so only pageant changes.
What the reviewer checked
- "windows-sys 0.61.2"
- "windows-sys 0.52.0" (7 places), - windows-core 0.62.2 + windows-core 0.61.2
Hand this to an agent
Act on a code-review finding.
File: Cargo.lock
Lines: 2041-2041
Category: correctness
Severity: low (reviewer confidence 0.50)
Finding:
This bump also moves several unrelated crates (socket2-style users, rustix, quinn-udp, tempfile, rustls-platform-verifier, iana-time-zone) from windows-sys 0.61.2 to 0.52.0, and one crate from windows-core 0.62.2 to 0.61.2. A pageant bump does not need this. It is a downgrade that adds an older copy of the Windows crates to Windows builds. Check whether pageant 0.2.5 requires it. If not, regenerate the lock so only pageant changes.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
There was a problem hiding this comment.
Takes the fix for GHSA-662x-8wvj-2276 (unbounded frame buffering). Nit: the lockfile rolls some Windows-only deps back (windows-sys 0.61.2 → 0.52.0), adding duplicate versions; cargo-deny bans still pass.
The session e2e now takes main's test-kvm to 28.5 of its 30 minutes (merge-queue run 41673262055 for gominimal#2824). Queue runs for gominimal#2831 and gominimal#2819 were cancelled at the limit while the e2e still made progress, and the queue dequeued both PRs.
Bumps pageant from 0.2.3 to 0.2.5.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.