8000 build(deps): bump pageant from 0.2.3 to 0.2.5 by dependabot[bot] · Pull Request #2824 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

build(deps): bump pageant from 0.2.3 to 0.2.5 - #2824

Merged
bryan-minimal merged 1 commit into
mainfrom
dependabot/cargo/pageant-0.2.5
Nov 3, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
dependabot/cargo/pageant-0.2.5

Conversation

@dependabot
@dependabot dependabot Bot commented on behalf of github Nov 1, 2026
Copy link
Copy Markdown
Contributor

Bumps pageant from 0.2.3 to 0.2.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [pageant](https://github.com/warp-tech/russh) from 0.2.3 to 0.2.5.
- [Release notes](https://github.com/warp-tech/russh/releases)
- [Commits](https://github.com/warp-tech/russh/commits)

---
updated-dependencies:
- dependency-name: pageant
  dependency-version: 0.2.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Nov 1, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner November 1, 2026 00:34
@dependabot dependabot Bot added the rust Pull requests that update rust code label Nov 1, 2026
@coderabbitai
coderabbitai Bot commented Nov 1, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 128f27d8-90e2-47cb-86a0-ff5130b4d51e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 1, 2026 •
Copy link
Copy Markdown
Contributor

Reviewed: 1 finding, none blocking at bfa539b1a2ef.

Address the comments on the diff.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread Cargo.lock
dependencies = [
"libc",
"windows-sys 0.61.2",
"windows-sys 0.52.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.50

This bump also moves several unrelated crates (socket2-style users, rustix, quinn-udp, tempfile, rustls-platform-verifier, iana-time-zone) from windows-sys 0.61.2 to 0.52.0, and one crate from windows-core 0.62.2 to 0.61.2. A pageant bump does not need this. It is a downgrade that adds an older copy of the Windows crates to Windows builds. Check whether pageant 0.2.5 requires it. If not, regenerate the lock so only pageant changes.

What the reviewer checked
  • "windows-sys 0.61.2"
  • "windows-sys 0.52.0" (7 places), - windows-core 0.62.2 + windows-core 0.61.2
Hand this to an agent
Act on a code-review finding.

File:       Cargo.lock
Lines:      2041-2041
Category:   correctness
Severity:   low (reviewer confidence 0.50)

Finding:
This bump also moves several unrelated crates (socket2-style users, rustix, quinn-udp, tempfile, rustls-platform-verifier, iana-time-zone) from windows-sys 0.61.2 to 0.52.0, and one crate from windows-core 0.62.2 to 0.61.2. A pageant bump does not need this. It is a downgrade that adds an older copy of the Windows crates to Windows builds. Check whether pageant 0.2.5 requires it. If not, regenerate the lock so only pageant changes.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 3, 2026
@norrietaylor
norrietaylor removed this pull request from the merge queue due to a manual request Nov 3, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 3, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes the fix for GHSA-662x-8wvj-2276 (unbounded frame buffering). Nit: the lockfile rolls some Windows-only deps back (windows-sys 0.61.2 → 0.52.0), adding duplicate versions; cargo-deny bans still pass.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 4137359 Nov 3, 2026
35 checks passed
@bryan-minimal
bryan-minimal deleted the dependabot/cargo/pageant-0.2.5 branch November 3, 2026 20:09
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Nov 4, 2026
The session e2e now takes main's test-kvm to 28.5 of its 30 minutes
(merge-queue run 41673262055 for gominimal#2824). Queue runs for gominimal#2831 and gominimal#2819
were cancelled at the limit while the e2e still made progress, and
the queue dequeued both PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0