Repository navigation
test(e2e): hold daemon 2's busy default port across its start - #2311
norrietaylor merged 2 commits into
Conversation
The beat D staging gated its stand-in holder for 127.0.0.1:7654 on a single check-then-act probe, so a transient holder (a daemon still draining from the stop above) could hold the port at the probe, release before the second daemon started, and leave the default free: no relocation happened and the NET-025 warn was never owed, failing the proof spuriously. Wait out any foreign holder, then hold the port with this run's own stand-in, confirming the bind via a ready-file handshake, and treat a persistent foreign listener as a valid holder of the busy default. Assert daemon 2 never reports 7654 so the staging fails loudly at the source instead of at a downstream grep.
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 39 minutes for your next included review. Che 8000 ck out review usage here. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly and concisely describes the main change: keeping daemon 2's default port occupied during startup. |
| Description check | |
The description explains the problem, the fix, and verification results. It uses “Verification” instead of the template’s “Testing” heading and omits the checklist, but it provides the required substa… |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 too large.)
Full details: Description check
-
Explanation
The description explains the problem, the fix, and verification results. It uses “Verification” instead of the template’s “Testing” heading and omits the checklist, but it provides the required substantive information.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit waits beside the gate,
While port 7654 keeps its state.
A holder signals, clear and bright,
The daemon picks a different site,
And hops away into the night.
Comment @coderabbitai help to get the list of available commands.
When the pin is 7654, daemon 1 holds the default, so daemon 2 on 7654 is a same-port failure; let the same-port assert diagnose it.
|
/review |
There was a problem hiding this comment.
Approved on ARCH PASS at 5c9a16e.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABU7kqog
The two-daemon recovery proof staged daemon 2's busy default port
(127.0.0.1:7654) with a single check-then-act probe: a transient holder
could release before daemon 2 started, leaving the default free — no
relocation, so the NET-025 warn the proof asserts was never owed
(informed by #627). Beat D now waits out any foreign holder, then holds
7654 with this run's own stand-in (ready-file handshake, three-way
outcome), and asserts daemon 2 never reports 7654.
Verification
cargo fmt --all --check --manifest-path target/Cargo.toml— passcargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml -- -D warnings— passcargo test -pcrate applies; clippy type-checked all test codeSummary by CodeRabbit