Repository navigation
fix(minimal): spell network modes as host_ip, own_ip and none in min dash - #2310
Conversation
The min dash TUI rendered network modes as Rust enum names: the detail pane's net row used the Debug representation (HostNet, OwnIp, NoNet) and the sidebar label used Host, OwnIp, NoNet, while every other CLI surface spells the canonical --network vocabulary (host_ip, own_ip, none) via NetworkMode::word(). Route all three dash sites through mode.word(), keeping the fallback arm for the #[non_exhaustive] future variants. Sidebar width math self-adjusts, so the wider labels need no layout changes. Add a render test asserting the detail pane spells net own_ip and update the affected dash snapshots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the main change and follows the required Conventional Commit format. |
| Description check | |
The description explains the change, rationale, affected behavior, and verification results. It omits the template's explicit Checklist section, but the required technical information is mostly comple… |
| Docstring Coverage | |
Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the change, rationale, affected behavior, and verification results. It omits the template's explicit Checklist section, but the required technical information is mostly complete.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the dashboard glow
Network words now plainly show own_ip appears in the pane
The sidebar spells it out again
Hops a test through each display
Then bounds along its way
Comment @coderabbitai help to get the list of available commands.
The wildcard arm rendered a future NetworkMode variant as "Custom" while the CLI would print its word. word() is exhaustive in boxes, so the arm and its stale comment go.
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
Approved on ARCH PASS at 46dbc80.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABX3vcWg
The min dash TUI rendered network modes as Rust enum names: the
detail pane's net row used the Debug representation (HostNet,
OwnIp, NoNet) and the sidebar label used Host, OwnIp, NoNet, while
every other CLI surface (the --network flag, session policy output)
spells the canonical vocabulary host_ip, own_ip, none via
NetworkMode::word(). Route the three dash sites through mode.word(),
keeping the fallback arm for #[non_exhaustive] future variants. The
sidebar width math self-adjusts to the wider labels, so no layout
changes were needed. Snapshots were regenerated accordingly.
Verification
cargo fmt --all --check— passcargo clippy --workspace --all-targets --locked -- -D warnings— passcargo test --locked -p minimal --no-fail-fast— all dash tests pass(dash_snapshots: 21/21, including the new test); one pre-existing,
unrelated failure (
tests::legacy_network_spellings_parse_with_hint)reproduced identically on unmodified main via git stash and touches
CLI --network deprecation hints, with zero file overlap with this diff.
detail_pane_spells_the_network_mode_wordassertsthe detail pane's net row spells
net own_ipand never showsOwnIp; the existing sidebar truncation test now assertsown_ip.No
cargo runrepro since the TUI needs a live daemon; the rendertest exercises the same code path in-tree.
Summary by CodeRabbit
OwnIpmode is displayed asown_ip, making network values consistent across dashboard views.