Repository navigation
fix(minimald): log the box name plainly in shared-port hand-over lines - #2308
Conversation
Four log sites in box_actor.rs logged the box name with Rust Debug
formatting (name=Some("n2-a8")), which defeats the greps a diagnostics
bundle is written against and diverges from the session_name=<plain>
convention used by every sibling line. Render the name through
as_deref().unwrap_or("-") under the session_name field instead,
matching the ANONYMOUS_SESSION idiom in rpc.rs.
Tests: pin the rendered hand-over info line and the refused-report
warn line to session_name=<plain>.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly and concisely describes the main change: logging the box name plainly in shared-port hand-over lines. It also follows the required Conventional Commit format. |
| Description check | |
The description explains the change and motivation, and it provides detailed verification results, including the known pre-existing test failures. It omits the template's exact Summary, Testing, and C… |
Full details: Description check
-
Explanation
The description explains the change and motivation, and it provides detailed verification results, including the known pre-existing test failures. It omits the template's exact Summary, Testing, and Checklist headings, but the required information is mostly present.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit reads the logs at night
Session names now print just right
If no name comes, a dash will show
Handover tests confirm the flow
One neat field, then off I go
Comment @coderabbitai help to get the list of available commands.
The shared-port hand-over lines and the session-start network line now
fall back to ANONYMOUS_SESSION ("<anonymous>"), the placeholder every
other session_name line uses. The refused host-address create line
renders session_name plainly instead of as a Debug-formatted Option.
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
Approved on ARCH PASS at a34efbf.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABX3vU2w
Four log sites in
crates/minimald/src/box_actor.rslogged the box name with Rust Debug formatting (name=Some("n2-a8")) instead of the plain name, defeating the greps a diagnostics bundle is written against and diverging from thesession_name=<plain>convention every sibling line uses.They now render the name via
record.name.as_deref().unwrap_or(crate::rpc::ANONYMOUS_SESSION)under thesession_namefield, so an unnamed box logs<anonymous>like every othersession_nameline. The refused host-address create line inbox_manager.rshad the same Debug rendering (session_name=Some(..)) and now renders it plainly too. Tests pin the rendered hand-over info line, the refused-report warn line, and the refused-create line.Verification
cargo fmt --all --check— passcargo clippy --workspace --all-targets --locked -- -D warnings— passcargo test --locked -p minimald— 999 passed, 11 failed; all 11 fail identically on unmodifiedmainin this container (verified viagit stash+ rerun: same 11 tests fail on pristine main, pre-existing cross-test log-capture pollution, not caused by this change). Both tests covering this fix pass in isolation and in the full suite run.Summary by CodeRabbit
-when no name is set.