Repository navigation
fix: move canonical_box_name into box_registry - #2344
norrietaylor merged 1 commit into
Conversation
box_registry imported net::answerer::canonical_box_name while answerer imported box_registry's types, so the two modules imported each other. The helper belongs with the registry that holds the rows it names: move it to box_registry, keep the one-directional edge (answerer imports box_registry), and repoint the two fully-qualified call sites and the intra-doc links. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: moving canonical_box_name into box_registry. It follows the required Conventional Commit format. |
| Description check | |
The description explains the change, motivation, affected modules, and verification results. It includes testing evidence and documents the three known baseline test failures. It does not use the temp… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the change, motivation, affected modules, and verification results. It includes testing evidence and documents the three known baseline test failures. It does not use the template headings exactly and omits the checklist, but the required information is mostly present.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 too large.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks each name in flight
And folds its letters into lowercase right
The registry keeps the shared routine
The answerer calls it, clear and clean
The gate follows the same design
Comment @coderabbitai help to get the list of available commands.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABYJPqGA
crates/minvmd/src/box_registry.rsandcrates/minvmd/src/net/answerer.rsimported each other: box_registry pulled
canonical_box_namefromnet::answerer, while answerer pulledBoxRegistryandis_host_answerablefrom box_registry — an import cycle between theregistry and the answerer that resolve into one crate anyway.
The helper belongs with the registry that holds the rows it names, so
this moves it verbatim (with its doc comment) from
net::answerertobox_registry, folds answerer's use into its existingbox_registryimport, and repoints the two fully-qualified call sites and the
intra-doc links that named the old path. The import edge is now
one-directional:
net::answererimports frombox_registry, andbox_registryno longer imports fromnet::answererat all.Verification
cargo fmt --all --check --manifest-path target/Cargo.toml— cleancargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml -- -D warnings— cleancargo test --locked --manifest-path target/Cargo.toml -p minvmd— 575 passed, 3 failed; the 3 (a_warned_daemon_announces_its_first_registration,answerer_service_forgets_rows_of_a_gone_node,resolve_uds_path_lives_in_provider_dir) fail identically on unmodifiedmainundercargo test's shared-process runner — they install a global tracing subscriber / mutateXDG_STATE_HOMEand expect the process-per-test model ofcargo nextest, the runnerjust testusesgrep -n "use crate::net::answerer" crates/minvmd/src/box_registry.rs— no matches: the cycle edge is gonecargo nextestis not installed on this runner, so the suite was runwith
cargo test; the same three tests fail the same way before andafter this change.
Summary by CodeRabbit