8000 chore(deps): rustls 0.23.46 on release/0.7.0 (RUSTSEC-2026-0346, -0347, -0348, -0349) by norrietaylor · Pull Request #2210 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

chore(deps): rustls 0.23.46 on release/0.7.0 (RUSTSEC-2026-0346, -0347, -0348, -0349) - #2210

Merged
norrietaylor merged 1 commit into
release/0.7.0from
chore/rustls-0.23.46-0.7.0
Oct 14, 2026
Merged

norrietaylor merged 1 commit into
release/0.7.0from
chore/rustls-0.23.46-0.7.0

Conversation

@norrietaylor
Copy link
Copy Markdown
Member

Cherry-pick of #2206 onto release/0.7.0.

release/0.7.0 ships rustls 0.23.45, which four advisories published 2026-10-14 affect: Debug impls exposing TLS secrets (RUSTSEC-2026-0346), buffered application data sent after an ECH rejection (-0347), brotli certificate decompression allocating before authentication (-0348), and an unauthenticated ServerHello downgrading later connections (-0349). 0.23.46 fixes all four. The change is the lockfile bump and nothing else.

Without it, cargo-deny is red on the release branch, so 0.7.0 cannot be cut from it.

Verification

  • just deny on this branch (macOS): advisories ok, bans ok, licenses ok, sources ok.
  • The cherry-pick applied cleanly; Cargo.lock is the only file changed.

…2206)

Four rustls advisories published 2026-10-14 against 0.23.45 (Debug impls exposing
TLS secrets, buffered data after ECH rejection, brotli certificate decompression
before authentication, ServerHello downgrade). Lockfile-only: 0.23.46 is the
patched release. cargo-deny is red on main and on every PR until this lands.

(cherry picked from commit 598e6d8)
@norrietaylor
norrietaylor requested a review from a team as a code owner October 14, 2026 20:30
@coderabbitai
coderabbitai Bot commented Oct 14, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: b2619025-0c01-419f-997c-ff8a05ae7f04

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry
minimal-foundry Bot commented Oct 14, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 73c62d49fecc.

Nothing to do.

Clobber: none: the base on this branch pinned 0.23.45 and the prior commits are unrelated release-candidate declarations; no recent fix is reverted. Consistency verified structurally: exactly one rustls package in Cargo.lock, now at 0.23.46, so the affected 0.23.45 is fully removed (no dangling copy remains), and the new checksum 48e13bd8… matches the genuine crates.io checksum for rustls 0.23.46…

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness

minimal-review — approved

Verdict APPROVE — No findings.

security

minimal-review — approved

Verdict APPROVE — No findings.

supply-chain

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 14, 2026
@norrietaylor
norrietaylor merged commit aa18ed0 into release/0.7.0 Oct 14, 2026
29 checks passed
@norrietaylor
norrietaylor deleted the chore/rustls-0.23.46-0.7.0 branch October 14, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0