Repository navigation
docs(telemetry): DO_NOT_TRACK needs a non-empty value; link spec 25 by URL - #2209
Conversation
…pec 25 by URL The opt-out table said any value of DO_NOT_TRACK disables telemetry while the paragraph below it says the value must be non-empty; the table now agrees with the paragraph. The spec 25 link was relative to docs/specs, which the website's docs sync never carries, so the synced page 404ed on it; an absolute repository URL resolves in both places. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wm1YgysmSMp3upJQvZJHwt
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes both documentation changes. It uses the expected Conventional Commit format and identifies the affected telemetry behavior and link. |
| Description check | |
The description explains what changed, why it changed, and references the related issue. The Testing section is not completed, but the description is otherwise substantially complete for this document… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Vale (3.22.0)
-
{
"Line": 0,
"Path": "",
"Text": "E100 [loadStyles] Runtime error\n\nstyle 'ste' does not exist on StylesPath\n\nExecution stopped with code 1.",
"Code": "E100",
"Span": 0
}
A rabbit checks the link with care,
Then finds the opt-out wording there.
A value empty does not apply,
A non-empty one can say goodbye.
The reference hops, precise and bright.
Comment @coderabbitai help to get the list of available commands.
|
Approved: no findings at Nothing to do. Clobber: none — |
There was a problem hiding this comment.
correctness
minimal-review — approved
Verdict APPROVE — No findings.
security
minimal-review — approved
Verdict APPROVE — No findings.
supply-chain
minimal-review — approved
Verdict APPROVE — No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
Heads-up so we do not collide: #2207 (the OTel follow-ups, item 7 of #2202) carries the same change to the |
Two lines in
docs/reference/telemetry.md, both raised by reviewers on the website's docs sync (gominimal/webapp#879), where this page is published verbatim:DO_NOT_TRACKdisables telemetry; the paragraph under it says the value must be non-empty. The table now says non-empty.docs/specs/, which the website sync never carries, so the published page 404ed on it. It now links the file by repository URL, which resolves in the repo and on the site.🤖 Generated with Claude Code
https://claude.ai/code/session_01Wm1YgysmSMp3upJQvZJHwt
Summary by CodeRabbit
DO_NOT_TRACKcontains any non-empty value. Empty values do not meet this opt-out condition.