8000 ci(spec-lint): read the linter from foundry's spec plugin (#2240) by norrietaylor · Pull Request #2241 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

ci(spec-lint): read the linter from foundry's spec plugin (#2240) - #2241

Merged
norrietaylor merged 2 commits into
mainfrom
ci/spec-lint-reads-the-spec-plugin
Oct 18, 2026
Merged

ci(spec-lint): read the linter from foundry's spec plugin (#2240)#2241
norrietaylor merged 2 commits into
mainfrom
ci/spec-lint-reads-the-spec-plugin

Conversation

@norrietaylor
@norrietaylor norrietaylor commented Oct 17, 2026
Copy link
Copy Markdown
Member

Problem

gominimal/foundry is moving its spec linter from spec/ to plugins/spec/linter/ (gominimal/foundry#158). The installed .github/workflows/spec-lint.yml here sparse-checks out spec and runs linter/spec/spec_lint.py. Once the move lands on foundry main that path is gone: the advisory lint would skip with only a ::warning::, and foundry's spec-drift check, which lists minimal in COPY_REPOS, would go red.

Change

One file, .github/workflows/spec-lint.yml, three path edits:

  • the header comment names the new source of record, gominimal/foundry:plugins/spec/linter/deploy/spec-lint.yml
  • sparse-checkout: plugins/spec/linter
  • the existence check and the invocation read linter/plugins/spec/linter/spec_lint.py

No behaviour change. Nothing else in the file is touched.

Known and out of scope: this installed copy already differed from foundry's source before this PR (foundry's copy carries later hardening, for example the checked changed-file read and the author-scoped comment lookup; this copy carries a local zizmor comment and a # v3 pin label). Those differences are on origin/main today and are unchanged here. Reconciling them is a behaviour change and belongs in its own PR.

Merge order

  1. The gominimal/foundry layout PR, from branch layout/foundry-is-organized-by-factory-stage (tracking gominimal/foundry#158). Before it lands, plugins/spec/linter/ does not exist on foundry main.
  2. The paired gominimal/agent-runtime patch (gominimal/agent-runtime#356).
  3. This PR.

This PR stays a draft until the foundry layout PR has merged; mark it ready only then.

Test plan

  • The three changed lines match plugins/spec/linter/deploy/spec-lint.yml on the foundry branch layout/foundry-is-organized-by-factory-stage (compared with diff; the only other differences are the pre-existing ones named above).
  • git diff origin/main touches only .github/workflows/spec-lint.yml, 4 lines.
  • The workflow lists itself under paths, so this PR runs it. Before foundry merges, expect the ::warning::the linter could not be checked out quiet path and a green job. After foundry merges, re-run it and expect the linter to run.
  • After merge, foundry's spec-drift reports no new drift for gominimal/minimal from the path change.

Closes #2240

@coderabbitai
coderabbitai Bot commented Oct 17, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9d0e2fd6-e700-4a34-a342-09ccc1a30f9a
📥 Commits

Reviewing files that changed from the base of the PR and between c5b6dcd and f5493c5.

📒 Files selected for processing: 1
  • .github/workflows/spec-lint.yml
+-------------------------------------------------------------------+
| Your commit message says 'quick fix'. That's how folklore starts. |
+-------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor mentioned this pull request Oct 17, 2026
Closed
@norrietaylor
norrietaylor force-pushed the ci/spec-lint-reads-the-spec-plugin branch from 56c49eb to c79a10e Compare October 17, 2026 19:36
@norrietaylor
norrietaylor marked this pull request as ready for review October 18, 2026 03:06
@norrietaylor
norrietaylor requested a review from a team as a code owner October 18, 2026 03:06
@minimal-foundry
minimal-foundry Bot commented Oct 18, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Approved: no findings at c79a10e9ec9c.

Nothing to do.

Clobber: none: git log -- .github/workflows/spec-lint.yml shows the previous touches were unrelated (token scoping, template addition); nothing reverted.

minimal-foundry[bot]
minimal-foundry Bot approved these changes Oct 18, 2026
View reviewed changes
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 18, 2026
bryan-minimal
bryan-minimal approved these changes Oct 18, 2026
View reviewed changes
@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against foundry main: plugins/spec/linter/spec_lint.py and its deploy/spec-lint.yml are there and the old spec/ path is gone, so this is needed now. Three path edits, nothing else touched.

@norrietaylor
norrietaylor merged commit 51c1348 into main Oct 18, 2026
10 of 11 checks passed
@github-actions
github-actions Bot commented Oct 18, 2026
Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/TEMPLATE.md — 6 finding(s)

docs/specs/TEMPLATE.md:72: S006 `## Context` states nothing the template did not
docs/specs/TEMPLATE.md:81: S007 `**Success:**` is unanswered
docs/specs/TEMPLATE.md:83: S007 `**First slice:**` is unanswered
docs/specs/TEMPLATE.md:92: S007 `**Roles:**` is unanswered
docs/specs/TEMPLATE.md:199: S006 `## Design reasoning` states nothing the template did not
docs/specs/TEMPLATE.md:212: S007 `**Generality:**` is unanswered

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@444425d3, spec format: How Minimal Writes Specs.

@norrietaylor
norrietaylor deleted the ci/spec-lint-reads-the-spec-plugin branch October 18, 2026 23:52
@norrietaylor norrietaylor mentioned this pull request Oct 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryan-minimal bryan-minimal bryan-minimal approved these changes
@minimal-foundry minimal-foundry[bot] minimal-foundry[bot] approved these changes

Assignees

No one assigned

Labels

review:approved minimal-review approved the current head

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ci: spec-lint reads the linter from foundry's spec plugin

2 participants

@norrietaylor @bryan-minimal
0