Repository navigation
test(switch): gate bep_host socket tests under miri - #2165
norrietaylor merged 2 commits into
Conversation
The stack-peer integration tests in bep_host bind real Unix sockets and create temp dirs. Miri's default isolation refuses mkdir and cannot interpret the socket syscalls, so the nightly miri lane fails in bep_host::tests. Gate each of the twenty socket-backed tests with #[cfg_attr(miri, ignore)], the pattern the subnet/MAC/vsock tests in lib.rs already use. The pure in-memory ARP/RST/UDP/delivery tests keep running under Miri unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change excludes socket- and temporary-directory-based tests under Miri while retaining in-memory tests. No actionable behavior risk is established; the reported test totals should be corrected, but the discrepancy alone does not block merging. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 2 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly identifies the test changes and the Miri-specific gating for socket-based bep_host tests. It is concise and follows the repository's Conventional Commit format. |
| Description check | |
The description explains the change, its purpose, affected tests, and verification results. It does not use the template's exact ## Summary, ## Testing, and ## Checklist headings, but it provide… |
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the socket tests at night
Under Miri, they pause from their usual flight
The in-memory pairs still hop along
While loopback waits beyond the song
In other runs, tests carry on right
Comment @coderabbitai help to get the list of available commands.
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
the_real_probe_covers_the_whole_range binds real TCP sockets, which Miri's isolation refuses, so the run aborted there once the bep_host socket tests ahead of it were ignored. Gate it like them, and state the gating rule once at the top of the bep_host test module.
|
/review |
There was a problem hiding this comment.
Approved on ARCH PASS at 88ece6b.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABWepU6w
The
bep_hoststack-peer integration tests bind real Unix sockets and create temp dirs. Under the nightly Miri lane (cargo miri test -p switch), Miri's default isolation refusesmkdirand cannot interpret the socket syscalls, so the lane fails inbep_host::testsinstead of covering the primitives it was added to check.Each of the twenty socket-backed tests is now gated
#[cfg_attr(miri, ignore)]— the same pattern the subnet/MAC/vsock tests inlib.rsalready use.loopback::tests::the_real_probe_covers_the_whole_rangeis gated the same way: it binds real TCP sockets, which Miri's isolation refuses, and it is the test the run aborted on beforebep_hostlanded. The pure in-memory ARP/RST/UDP/delivery tests inbep_hostkeep running under Miri unchanged, so the lane still covers them.Verification
cargo fmt --all --check --manifest-path target/Cargo.toml— pass, no driftcargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml -- -D warnings— pass, no warningscargo test --locked --manifest-path target/Cargo.toml -p switch— 61 passed, 0 failed, 0 ignored (all tests still run off the miri cfg)RUSTFLAGS="--cfg miri" cargo test --locked --manifest-path target/Cargo.toml -p switch— 33 passed, 0 failed, 28 ignored: the 20 newly gatedbep_hosttests, the gatedloopbackreal-probe test, and the 7 pre-existinglib.rsgates are skipped under the miri cfg, and the pure tests still runjust miri(cargo +nightly miri test -p switch) on a macOS arm64 host, at 88ece6b —test result: ok. 33 passed; 0 failed; 28 ignored. This is real Miri, so the 33 ungated tests (bep_hostin-memory,loopbackinjected-binder,refusal,lib.rs) are interpreted clean under isolation.The nightly Miri lane runs on Linux, so its next scheduled run remains the proof for that target.
Summary by CodeRabbit