8000 fix(minimal): render plain console warnings as warning/error lines by gominimal-aw-bot[bot] · Pull Request #2022 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): render plain console warnings as warning/error lines - #2022

Merged
norrietaylor merged 2 commits into
mainfrom
inbox-patch/fix/console-layer-warning-format-d504b06d2efc699f
Oct 6, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
inbox-patch/fix/console-layer-warning-format-d504b06d2efc699f

Conversation

@gominimal-aw-bot
@gominimal-aw-bot gominimal-aw-bot Bot commented Oct 6, 2026 •
Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABVa6l7w

Problem

The min CLI's plain console layer (no RUST_LOG in effect) rendered
user-facing warnings through the default tracing format, producing a padded,
upper-case level record ( WARN ...) instead of a warning: ... line. The
upgrade hint for unknown minimal.toml keys also printed as a second warning
rather than a help: line.

Change

Replace the plain branch's default format in console_layer with a small
FormatEvent that writes warning: for WARN and error: for ERROR,
leaving INFO and below as the bare message. A message already starting with
help: is written as a help line with no level prefix. The RUST_LOG path
keeps the full tracing format (timestamp and target) unchanged.

Verification

  • cargo fmt --all --check — clean
  • cargo clippy --workspace --all-targets --locked -- -D warnings — clean
  • cargo test --locked -p minimal --bin min — 13 passed

Summary by CodeRabbit

  • Improvements
    • Runs without RUST_LOG now display warnings with a warning: prefix and errors with an error: prefix. Warning messages beginning with help: keep their existing prefix, and other log levels remain unprefixed.
    • Runs with RUST_LOG continue to use the full tracing format.

The plain console layer (no RUST_LOG) rendered WARN events through the
default tracing format, producing a padded, upper-case level record
(" WARN ...") instead of a user-facing "warning: ..." line. The upgrade
hint for unknown minimal.toml keys also printed as a second warning
rather than a "help:" line.

Replace the plain branch's default format with a small FormatEvent that
writes "warning: " for WARN and "error: " for ERROR, leaving INFO and
below as the bare message. A message already starting with "help:" is
written as a help line with no level prefix. The RUST_LOG path keeps the
full tracing format unchanged.
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner October 6, 2026 18:51
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Oct 6, 2026
@coderabbitai
coderabbitai Bot commented Oct 6, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 35 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 14002e38-f86a-4742-9e5a-2fde0a52765d
📥 Commits

Reviewing files that changed from the base of the PR and between 34b110c and 6ebb0b3.

📒 Files selected for processing (1)
  • crates/minimal/src/main.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 79106522-6917-4ff0-8bb0-ee77a1659b9e
📥 Commits

Reviewing files that changed from the base of the PR and between 2367ec6 and 34b110c.

📒 Files selected for processing (1)
  • crates/minimal/src/main.rs

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


📝 Walkthrough

Walkthrough

The plain tracing output now prefixes WARN messages with warning: , except messages starting with help:, and ERROR messages with error: . Runs with RUST_LOG retain the full tracing format.

Changes

Plain tracing output

Layer / File(s) Summary
Formatter and output tests
crates/minimal/src/main.rs
The plain formatter adds prefixes for WARN and ERROR events while retaining event fields and a trailing newline. Tests cover warning, help, and error output. The existing formatter path remains when plain formatting is disabled.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: 0chroma

Merge Risk: ⚪ Minimal · up to 34b11

The change adjusts how warnings and errors are displayed in plain console output. No actionable merge risk was found.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the plain console warning and error formatting change.
Description check ✅ Passed The description explains the problem and change, and reports verification commands and results. It omits the template’s Checklist section.
✨ Fin 8000 ishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the warning line,
“warning:” makes the message shine.
For “help:” the prefix hops away,
“error:” marks the trouble’s say.
Then fields and newline close the day.

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor changed the title fix: Render plain console warnings as warning/error lines fix(minimal): render plain console warnings as warning/error lines Oct 6, 2026
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Oct 6, 2026
@norrietaylor
Copy link
Copy Markdown
Member

/review

@minimal-foundry
minimal-foundry Bot commented Oct 6, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 6ebb0b3ebbb0.

Nothing to do.

Clobber: none: git log -- crates/minimal/src/main.rs shows the two commits on this branch (the fix and a docs follow-up) building on an earlier fix; nothing reverted.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 6, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review approved this head; CodeRabbit approved the code (later commit is doc comments only); 0 unresolved threads.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 0c7017a Oct 6, 2026
35 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/fix/console-layer-warning-format-d504b06d2efc699f branch October 6, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0