8000 fix: hide host sessions path for minvmd-backed dirs by gominimal-aw-bot[bot] · Pull Request #1933 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix: hide host sessions path for minvmd-backed dirs - #1933

Merged
norrietaylor merged 1 commit into
mainfrom
inbox-patch/fix/min-dirs-sessions-row-minvmd-3d680459cf4c98fe
Oct 5, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
inbox-patch/fix/min-dirs-sessions-row-minvmd-3d680459cf4c98fe

Conversation

@gominimal-aw-bot
@gominimal-aw-bot gominimal-aw-bot Bot commented Oct 4, 2026 •
Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABU3iCMw

On minvmd-backed hosts the session store lives inside the VM, so the
host sessions path is never created. min dirs still listed it as a
missing host path. Branch the Sessions row on the provider: minvmd
shows no host path and notes the store is inside the VM; the native
provider keeps the host sessions path.

Verification

cargo fmt --check --manifest-path target/Cargo.toml  # passes
cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings  # passes (1.97.0)
cargo build --workspace --locked --manifest-path target/Cargo.toml  # passes
cargo test -p minimal --lib dirs --locked --manifest-path target/Cargo.toml  # 5 passed

Pre-existing test failures in checkouts (2) and minimal
(legacy_network_spellings_parse_with_hint) are unrelated to this
change and reproduce on unmodified main in this container.

Summary by CodeRabbit

  • Bug Fixes
    • The Sessions row now shows the correct location for each provider: inside the VM for Minvmd, and in the state directory for Minimald.

On minvmd-backed hosts the session store lives inside the VM, so the
host sessions path is never created. `min dirs` still listed it as a
missing host path. Branch the Sessions row on the provider: minvmd
shows no host path and notes the store is inside the VM; the native
provider keeps the host sessions path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner October 4, 2026 04:44
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Oct 4, 2026
@coderabbitai
coderabbitai Bot commented Oct 4, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 6f624b33-d0f3-4ccd-9f0f-d272f68b0fb7
📥 Commits

Reviewing files that changed from the base of the PR and between 588fbde and 269c372.

📒 Files selected for processing (1)
  • crates/minimal/src/dirs.rs

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The Sessions row now depends on the provider. Minvmd displays an in-VM note without a host path. Minimald retains the state-directory sessions path. A test checks both cases.

Changes

Sessions path reporting

Layer / File(s) Summary
Provider-specific Sessions row
crates/minimal/src/dirs.rs
The Sessions row has no host path and displays “inside the VM; not on this host” for Minvmd. For Minimald, it retains the state-directory sessions path. A test checks both results.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: evanspearman

Merge Risk: ⚪ Minimal · up to 269c3

The change reports the sessions location according to provider; no merge-blocking risk is evident in the supplied change context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change and follows the repository’s Conventional Commit format.
Description check ✅ Passed The description explains the change and why it is needed, and it reports verification commands and results. It does not use the template’s Summary and Testing headings or include the Checklist, but th…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the paths today
No host path where the VM holds sway
Minimald keeps its sessions near
Two tested cases make the output clear
The rabbit hops away with cheer

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@minimal-foundry
minimal-foundry Bot commented Oct 4, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 269c372b43ce.

Nothing to do.

Clobber: none — git log on the file shows the head commit is the PR itself; no recent fix reverted.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 4, 2026
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Oct 4, 2026
@norrietaylor
Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai
coderabbitai Bot commented Oct 4, 2026 •
Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@norrietaylor
Copy link
8000 Copy Markdown
Member

@coderabbitai review

@coderabbitai
coderabbitai Bot commented Oct 5, 2026 •
Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit and minimal-review approved this head; 0 unresolved threads; all lanes green.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 908b5a8 Oct 5, 2026
35 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/fix/min-dirs-sessions-row-minvmd-3d680459cf4c98fe branch October 5, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0