Repository navigation
fix: hide host sessions path for minvmd-backed dirs - #1933
norrietaylor merged 1 commit into
Conversation
On minvmd-backed hosts the session store lives inside the VM, so the host sessions path is never created. `min dirs` still listed it as a missing host path. Branch the Sessions row on the provider: minvmd shows no host path and notes the store is inside the VM; the native provider keeps the host sessions path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Sessions row now depends on the provider. Minvmd displays an in-VM note without a host path. Minimald retains the state-directory sessions path. A test checks both cases. ChangesSessions path reporting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change reports the sessions location according to provider; no merge-blocking risk is evident in the supplied change context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit checks the paths today Comment |
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none — |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
There was a problem hiding this comment.
CodeRabbit and minimal-review approved this head; 0 unresolved threads; all lanes green.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABU3iCMw
On minvmd-backed hosts the session store lives inside the VM, so the
host sessions path is never created.
min dirsstill listed it as amissing host path. Branch the Sessions row on the provider: minvmd
shows no host path and notes the store is inside the VM; the native
provider keeps the host sessions path.
Verification
Pre-existing test failures in
checkouts(2) andminimal(
legacy_network_spellings_parse_with_hint) are unrelated to thischange and reproduce on unmodified
mainin this container.Summary by CodeRabbit