8000 docs(specs): say none boxes keep the inet families their netns confines by norrietaylor · Pull Request #1922 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

docs(specs): say none boxes keep the inet families their netns confines - #1922

Merged
norrietaylor merged 1 commit into
mainfrom
docs/spec-18-net137-none-inet
Oct 7, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
docs/spec-18-net137-none-inet

Conversation

@norrietaylor
Copy link
Copy Markdown
Member

Rewords the NET-137 annotation in spec 18. It said only own-address and host-address boxes keep their inet families, which reads as excluding `none` boxes. A `none` box's fresh network namespace confines AF_INET/AF_INET6/AF_NETLINK (it holds only loopback), so it keeps them too. The EARS requirement text is unchanged.

Motivated by #1883, which admits those families in the none seal when the box has its own namespace.

just lint-prose reports no alerts on the touched line; the file's totals match main.

The NET-137 annotation said only own-address and host-address boxes keep
their inet families. A `none` box's fresh network namespace confines them
too, holding only loopback, so it keeps them as well.
@coderabbitai
coderabbitai Bot commented Oct 4, 2026 •
Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 40 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5e85d38a-f77e-47ee-9a3e-066f74076944
📥 Commits

Reviewing files that changed from the base of the PR and between 0a4bdb6 and 2dfcc76.

📒 Files selected for processing (1)
  • docs/specs/18-spec-box-networking/18-spec-box-networking.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot commented Oct 4, 2026
Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/18-spec-box-networking/18-spec-box-networking.md — 13 finding(s)

docs/specs/18-spec-box-networking/18-spec-box-networking.md:159: P004 NET-009 names test 'native_resolution_without_proxy_env', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:304: P004 NET-040 names test 'fresh_install_own_ip_ingress_publishes_loopback', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:309: P004 NET-041 names test 'installer_switch_binary_executable', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:328: P004 NET-045 names test 'expose_ask_prompts_attached_human', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:337: P004 NET-046 names test 'expose_unenrolled_decision_audited', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:347: P004 NET-048 names test 'linux_amd64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:352: P004 NET-049 names test 'fresh_linux_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:357: P004 NET-050 names test 'linux_arm64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:362: P004 NET-051 names test 'fresh_arm64_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:652: P004 NET-139 names test 'vsock_rpc_refuses_non_host_cid', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:669: P004 NET-132 names test 'proxy_sees_each_vm_box_by_its_switch_address', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:695: P004 NET-134 names test 'deny_all_box_reaches_proxy_and_no_other_host_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:719: P004 NET-107 names test 'session_outbound_request', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@b913de94, spec format: How Minimal Writes Specs.

@norrietaylor
norrietaylor marked this pull request as ready for review October 6, 2026 05:33
@norrietaylor
norrietaylor requested a review from a team as a code owner October 6, 2026 05:33
@minimal-foundry
minimal-foundry Bot commented Oct 6, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 2dfcc76705ec.

Nothing to do.

Clobber: none: git log on the file shows the PR head as the only recent edit, no prior fix reverted.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 6, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit c28425a Oct 7, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the docs/spec-18-net137-none-inet branch October 7, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0