Repository navigation
fix(e2e): reuse the native gvproxy switch in the fresh-install and bn proofs - #1972
Conversation
The native provisioning stages the pinned gvproxy switch at $WORK/gvproxy-bin/gvproxy-min. The fresh-install proof and the bn proof each fetched it again instead of reusing that copy, so a native run downloaded the switch twice. Add the staged copy as one more cascade source before the fetch fallback, keeping the fetch once per run and leaving the VM lanes unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughBoth gvproxy selection paths now check for an executable staged binary after the configured and scratch binaries and before the fresh-install fallback. The copy path copies the staged binary to the destination. Changesgvproxy binary selection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The fallback reuses the current run’s staged switch, while VM proof paths remain unchanged. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit checks the staged binary with care, Comment |
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
CodeRabbit and minimal-review approved this head; 0 unresolved threads; all lanes green.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABVA9jGQ
Summary
On the native Linux lane,
scripts/session-e2e.shdownloaded the pinned gvproxy switch twice per run: once during native provisioning (into$WORK/gvproxy-bin/gvproxy-min) and again in the fresh-install proof (into$WORK/fresh-install/gvproxy), which thebnproof then reused.This change adds the provisioning's staged copy (
$WORK/gvproxy-bin/gvproxy-min) as one more cascade source in both the fresh-install proof's gvproxy cascade and thebnproof's reuse, before the fetch fallback. A native run now fetches the switch at most once; VM lanes are unchanged.Verification
cargo fmt --all --check— cleancargo build --workspace --locked— cleancargo clippy --workspace --locked -- -D warnings— fails on pre-existingneedless_borrows_for_generic_argsincrates/args/src/lib.rs(untouched by this shell-only change)cargo test --workspace --locked— 2 pre-existing failures incrates/checkouts(git-clone path collisions in the sandbox), unrelated to this changeSummary by CodeRabbit