8000 fix(e2e): reuse the native gvproxy switch in the fresh-install and bn proofs by gominimal-aw-bot[bot] · Pull Request #1972 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(e2e): reuse the native gvproxy switch in the fresh-install and bn proofs - #1972

Merged
norrietaylor merged 1 commit into
mainfrom
inbox-patch/fix/gvproxy-single-fetch-68b5a7bea18538e4
Oct 5, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
inbox-patch/fix/gvproxy-single-fetch-68b5a7bea18538e4

Conversation

@gominimal-aw-bot
@gominimal-aw-bot gominimal-aw-bot Bot commented Oct 5, 2026 •
Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABVA9jGQ

Summary

On the native Linux lane, scripts/session-e2e.sh downloaded the pinned gvproxy switch twice per run: once during native provisioning (into $WORK/gvproxy-bin/gvproxy-min) and again in the fresh-install proof (into $WORK/fresh-install/gvproxy), which the bn proof then reused.

This change adds the provisioning's staged copy ($WORK/gvproxy-bin/gvproxy-min) as one more cascade source in both the fresh-install proof's gvproxy cascade and the bn proof's reuse, before the fetch fallback. A native run now fetches the switch at most once; VM lanes are unchanged.

Verification

  • cargo fmt --all --check — clean
  • cargo build --workspace --locked — clean
  • cargo clippy --workspace --locked -- -D warnings — fails on pre-existing needless_borrows_for_generic_args in crates/args/src/lib.rs (untouched by this shell-only change)
  • cargo test --workspace --locked — 2 pre-existing failures in crates/checkouts (git-clone path collisions in the sandbox), unrelated to this change

Summary by CodeRabbit

  • Chores
    • The end-to-end test environment can now use a staged gvproxy binary when available, while retaining existing binary selection and fallback behavior. This keeps the selected binary consistent across the test run.

The native provisioning stages the pinned gvproxy switch at
$WORK/gvproxy-bin/gvproxy-min. The fresh-install proof and the bn
proof each fetched it again instead of reusing that copy, so a native
run downloaded the switch twice. Add the staged copy as one more
cascade source before the fetch fallback, keeping the fetch once per
run and leaving the VM lanes unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner October 5, 2026 02:43
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Oct 5, 2026
@coderabbitai
coderabbitai Bot commented Oct 5, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 1b279ae4-2004-4a5d-a33f-e05b4742b18a
📥 Commits

Reviewing files that changed from the base of the PR and between d6da92d and 2d5c109.

📒 Files selected for processing (1)
  • scripts/session-e2e.sh

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


📝 Walkthrough

Walkthrough

Both gvproxy selection paths now check for an executable staged binary after the configured and scratch binaries and before the fresh-install fallback. The copy path copies the staged binary to the destination.

Changes

gvproxy binary selection

Layer / File(s) Summary
Staged binary fallback
scripts/session-e2e.sh
Both selection paths now check for an executable $WORK/gvproxy-bin/gvproxy-min after the configured and scratch binaries. One path selects it; the other copies it to $bn_bin/gvproxy-min. Both checks occur before the fresh-install fallback.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: norrietaylor

Merge Risk: ⚪ Minimal · up to 2d5c1

The fallback reuses the current run’s staged switch, while VM proof paths remain unchanged. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the required Conventional Commit format and clearly identifies the gvproxy reuse change in both proofs.
Description check ✅ Passed The description explains the change and its purpose, and reports verification results. It uses “Verification” instead of the template’s “Testing” heading and omits the checklist, but it is mostly comp…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the staged binary with care,
Then hops past the fallback, light as air.
If it can run, it joins the show,
Or copies to where gvproxy should go.
Two paths now know which way to roam.

Comment @coderabbitai help to get the list of available commands.

@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Oct 5, 2026
@norrietaylor norrietaylor changed the title fix: Reuse native gvproxy switch in fresh-install and bn proofs fix(e2e): reuse the native gvproxy switch in the fresh-install and bn proofs Oct 5, 2026
@norrietaylor
Copy link
Copy Markdown
Member

/review

@minimal-foundry
minimal-foundry Bot commented Oct 5, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 2d5c1093b213.

Nothing to do.

Clobber: none: git log -- scripts/session-e2e.sh shows the immediately prior commit d6da92d6 introduced the staging this PR reuses; this is the natural follow-on, nothing reverted.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 5, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit and minimal-review approved this head; 0 unresolved threads; all lanes green.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 5, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit d1614ba Oct 5, 2026
34 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/fix/gvproxy-single-fetch-68b5a7bea18538e4 branch October 5, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0