Repository navigation
fix(e2e): hold the default proxy port for the second daemon when beat A's holder is gone - #1876
Merged
Merged
Conversation
… A's holder is gone Beat A falls back to a spare pin when 7654 probes busy, and beat D assumed 7654 stays busy so the second daemon relocates. A daemon still shutting down from the case's own stop releases 7654 a moment later, so the second daemon bound its default and logged no relocation (main 1de96cd, 8000 native-daemon-e2e). Beat D now re-probes 7654 and holds it itself when free.
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 24 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Comment |
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main went red at
1de96cd9innative-daemon-e2e, case "hostnames recover, and two daemons share a machine":no relocation record in daemon 2's log. The cause is a race in the case itself, not #1861.mnl stop. The stopping daemon still held it, so the case pinned the spare 18754.two daemons: one on 127.0.0.1:18754, two on 127.0.0.1:7654), so no relocation warn was ever owed.Change
scripts/session-e2e.sh: beat D re-probes 7654 when beat A's pin is a spare. If it is free, the case holds it with the same python3 holder beat A uses, so the second daemon's default is busy. The holder is killed inrecover_two_daemon_cleanupand by the existing teardown trap.Verify
bash -nandshellcheck -S warningare clean.