8000 fix(e2e): hold the default proxy port for the second daemon when beat A's holder is gone by norrietaylor · Pull Request #1876 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(e2e): hold the default proxy port for the second daemon when beat A's holder is gone - #1876

Merged
norrietaylor merged 1 commit into
mainfrom
fix/e2e-recover-default-port-hold
Oct 3, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
fix/e2e-recover-default-port-hold

Conversation

@norrietaylor
Copy link
Copy Markdown
Member

Summary

Main went red at 1de96cd9 in native-daemon-e2e, case "hostnames recover, and two daemons share a machine": no relocation record in daemon 2's log. The cause is a race in the case itself, not #1861.

  • Beat A probes 7654 right after mnl stop. The stopping daemon still held it, so the case pinned the spare 18754.
  • Beat D assumes 7654 is still busy, so the second daemon must relocate. By then the old daemon had released it. Daemon 2 bound its default 7654 directly (two daemons: one on 127.0.0.1:18754, two on 127.0.0.1:7654), so no relocation warn was ever owed.

Change

scripts/session-e2e.sh: beat D re-probes 7654 when beat A's pin is a spare. If it is free, the case holds it with the same python3 holder beat A uses, so the second daemon's default is busy. The holder is killed in recover_two_daemon_cleanup and by the existing teardown trap.

Verify

  • bash -n and shellcheck -S warning are clean.
  • The race path only runs when beat A finds 7654 busy. The native lane on this PR covers the normal path, where the pin is 7654 and the new block is skipped.

… A's holder is gone

Beat A falls back to a spare pin when 7654 probes busy, and beat D
assumed 7654 stays busy so the second daemon relocates. A daemon still
shutting down from the case's own stop releases 7654 a moment later, so
the second daemon bound its default and logged no relocation (main
1de96cd,
8000
 native-daemon-e2e). Beat D now re-probes 7654 and holds it
itself when free.
@norrietaylor
norrietaylor requested a review from a team as a code owner October 3, 2026 09:34
@coderabbitai
coderabbitai Bot commented Oct 3, 2026
Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 24 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 50c657bb-803f-466f-9aa9-7caac9472acc
📥 Commits

Reviewing files that changed from the base of the PR and between 1de96cd and 7d53cf8.

📒 Files selected for processing (1)
  • scripts/session-e2e.sh
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry
minimal-foundry Bot commented Oct 3, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 7d53cf842eac.

Nothing to do.

Clobber: none: git log on the file shows the PR's own commit as the only change since 1de96cd9; no fix reverted.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 3, 2026
@norrietaylor
norrietaylor merged commit d78716e into main Oct 3, 2026
35 checks passed
@norrietaylor
norrietaylor deleted the fix/e2e-recover-default-port-hold branch October 3, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0