8000 [worker:coverage] cover MissingRuntimeDeps::check interpreter and dep-cache paths by gominimal-aw-bot[bot] · Pull Request #1677 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

[worker:coverage] cover MissingRuntimeDeps::check interpreter and dep-cache paths - #1677

Merged
gominimal-aw-bot[bot] merged 1 commit into
mainfrom
chore/coverage-missing-runtime-deps-e2b76e13dbdc576e
Sep 24, 2026
Merged

[worker:coverage] cover MissingRuntimeDeps::check interpreter and dep-cache paths#1677
gominimal-aw-bot[bot] merged 1 commit into
mainfrom
chore/coverage-missing-runtime-deps-e2b76e13dbdc576e

Conversation

@gominimal-aw-bot
@gominimal-aw-bot gominimal-aw-bot Bot commented Sep 24, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Summary

Resolves the coverage gap reported in #1387 for check::outputs::MissingRuntimeDeps::check (regions=241).

The checker already had tests for its skip paths (skip_checkers, missing package, uncached build), the no-ELF-imports pass path, the missing-interpreter fail path, and the satisfied-interpreter pass path. This PR adds three tests covering the remaining observable branches:

  • allow_missing_interpreter = true opt-out: a shebang script whose interpreter is absent still reports Pass because the interpreter check is skipped.
  • Transitive runtime-dep cache miss: when the package build is cached but a declared runtime dependency is not, the checker reports Skip.
  • usr/bin interpreter fallback: a shebang script whose interpreter is provided by a runtime dep under usr/bin (not top-level bin) reports Pass.

Each test asserts the observable CheckVerdict and error list, not internal field assignments.

Verification

  • cargo build --workspace --all-targets passed.
  • cargo test -p check --lib outputs passed (9/9, including the 3 new tests).
  • cargo fmt --all --check passed.

The host backstop re-runs fmt-check + build --locked + clippy -D warnings + test before the PR opens.

Closes #1387

Generated by Chore-issue worker agent (side-repo-ops operator) · ⊞ 24.2K · ◷

Summary by CodeRabbit

  • Tests
    • Added coverage for interpreter checks when missing interpreters are allowed, runtime dependencies are uncached, and an interpreter is found in a dependency’s usr/bin path.

@gominimal-aw-bot
test(check): cover MissingRuntimeDeps::check interpreter and dep-cach…
bd4594c 
…e paths

Add tests for the allow_missing_interpreter opt-out, the
transitive-runtime-dep cache-miss skip, and the usr/bin interpreter
fallback, closing the remaining uncovered branches of the checker.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner September 24, 2026 07:43
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Sep 24, 2026
@gominimal-aw-bot
gominimal-aw-bot Bot enabled auto-merge (squash) September 24, 2026 07:43
@coderabbitai
coderabbitai Bot commented Sep 24, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: bdca2cd3-b6fe-4856-8e9c-d60213602a14

📥 Commits

Reviewing files that changed from the base of the PR and between 6356668 and bd4594c.

📒 Files selected for processing (1)
  • crates/check/src/outputs.rs

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

Walkthrough

Three tests were added for MissingRuntimeDeps. They cover an allowed missing interpreter, an uncached declared runtime dependency, and interpreter lookup through a dependency’s usr/bin path.

Changes

Runtime dependency checks

Layer / File(s) Summary
Checker outcome tests
crates/check/src/outputs.rs		 Tests assert Pass when the missing interpreter is allowed, Skip when a declared runtime dependency is not cached, and Pass when the interpreter is found under the dependency’s usr/bin path.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: 0chroma, twitchyliquid64

Merge Risk: ⚪ Minimal · up to bd459

The added tests cover the stated checker outcomes; no actionable merg 8000 e risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the added coverage for MissingRuntimeDeps::check and names the interpreter and dependency-cache paths.
Description check ✅ Passed The description provides a clear summary, linked issue, detailed test coverage, and verification results. It uses a "Verification" section instead of the template's "Testing" heading and omits the req…
Linked Issues check ✅ Passed The PR addresses #1387 with three async tests for MissingRuntimeDeps::check. The tests build dependency graphs, populate the mock cache, invoke check, and assert observable CheckVerdict and erro…
Out of Scope Changes check ✅ Passed The reviewed diff adds only tests in crates/check/src/outputs.rs. The tests directly exercise the function and branches named in #1387. No unrelated production behavior or unrelated files are change…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the scripts at night
Three tests make outcomes clear and bright
If missing tools are allowed, pass
If caches lag, skip comes to pass
usr/bin/sh is found in time
The rabbit hops away in rhyme

Comment @coderabbitai help to get the list of available commands.

@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Sep 24, 2026
@gominimal-aw-bot
gominimal-aw-bot Bot merged commit 294765a into main Sep 24, 2026
32 checks passed
@gominimal-aw-bot
gominimal-aw-bot Bot deleted the chore/coverage-missing-runtime-deps-e2b76e13dbdc576e branch September 24, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

agent:coverage: check::outputs::MissingRuntimeDeps::check is untested (regions=241)

1 participant

@norrietaylor
0