Repository navigation
chore(minimal-toml): pin pkgs at f4de33d0 and give sessions cargo-nextest - #1551
Conversation
…test gominimal/pkgs#720 added cargo-nextest 0.9.145, merged as f4de33d0. Every `test:` line the agent runtime runs for a task is `cargo nextest run …`, and it runs them in a sandbox that carries only its base set plus this file's `[session] packages`; with no nextest there, every task's tests fail before they compile and every pull request opens as a draft. The pin moves 65 pkgs commits (ff15baa9 → f4de33d0). That is the toolchain too — gcc, glibc, binutils, openssl, zlib, linux_headers, protobuf, skopeo, curl, and the virtio kernel and rootfs the VM outputs build from — so the dogfood and KVM lanes on this change are the proof, not this message. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 5 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe session package declaration adds ChangesSession package update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The session now includes cargo-nextest and the pinned configuration remains valid, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the package trail Comment |
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — APPROVE: all personas completed and nothing survives above severity 'nit' (0 finding(s) kept).
Scope matches the title exactly: two lines in .minimal/minimal.toml only, consistent with the declared changed_files. Clobber none: git log shows the prior commit on this file (4b42017b) touched [tasks.fmt]/[tasks.verify], not [upstream] or [session], so nothing is reverted. Correctness clean. I verified every load-bearing claim of the PR body against gominimal/pkgs: f4de33d0 exists with message "add cargo-nextest 0.9.145 (#720)"; the package is declared as "cargo-nextest" 0.9.145 with a pinned sha256; the compare API reports exactly ahead_by: 65, behind_by: 0, so the pin is a clean fast-forward as stated; and packages/cargo-nextest does not exist at the old pin ff15baa9, confirming the claim that the name alone would not have resolved. TOML parses (tomllib) with session.packages = ["just", "shellcheck", "python", "cargo-nextest"]. The 65-commit toolchain/VM-image drift (gcc, glibc, binutils, virtio-linux, microvm-rootfs) is disclosed in the PR body and is deliberately gated by the dogfood/KVM/native lanes on this PR — the same pattern as the prior pin bump (#1064); no finding warranted. Not checked: that the agent runtime's test sandbox actually reads this file's [session] packages (_packages_for, implement.py:630 — a different repo, outside this checkout), and the build itself, which needs a build.
What ran
7 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. git log --oneline -15 -- .minimal/minimal.toml — exit 0 · self-reported
Prior commit 4b42017 touched [tasks.fmt]/[tasks.verify], not upstream/session; no recent fix reverted by this PR.
2. GitHub API: repos/gominimal/pkgs/commits/f4de33d0... — self-reported
Commit exists; message "add cargo-nextest 0.9.145 (#720)"; adds packages/cargo-nextest/build.ncl + build.sh.
3. raw.githubusercontent.com pkgs f4de33d0 packages/cargo-nextest/build.ncl — self-reported
Package name "cargo-nextest", version "0.9.145", pinned sha256, runtime deps glibc + libgcc.
4. GitHub API: compare ff15baa9...f4de33d0 — self-reported
status "ahead", ahead_by 65, behind_by 0, merge_base == base: clean 65-commit fast-forward, matching the PR body.
5. GitHub API: packages/ listing at ff15baa9 — self-reported
No packages/cargo-nextest at the old pin (absent between capy and cf), confirming the name alone would not resolve.
6. grep -nE 'sk-[A-Za-z0-9]{20,}|AKIA...|gh[pousr]_...|BEGIN (RSA|OPENSSH|EC) PRIVATE' .review/pr.diff — exit 1 · self-reported
No credential patterns in the diff.
7. tomllib parse of .minimal/minimal.toml at head — self-reported
Parses; [session] packages = ["just", "shellcheck", "python", "cargo-nextest"]; locked_commit = f4de33d0...
minimal-review · schema minimal-review/v1 · persona generalist · model deepseek/deepseek-v4-flash-0731:nitro via claude-code · prompt review-prompt/v2 · head 6d2e1224db9a · verdict APPROVE · 0 finding(s), 0 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
Follow-up to #1542 for dispatching #1437 and #1501 through the agent runtime.
gominimal/pkgs#720 added
cargo-nextest0.9.145 (merged asf4de33d0). Everytest:line in both epics iscargo nextest run -p <crate> <filter>, and the runtime runs them host-side in a sandbox that gets only its base set plus this file's[session] packages(_packages_for,runner/runner/jobs/implement.py:630). Without the binary every task's tests fail before they compile and every agent PR opens as a draft — that was the state of the first canary's box.Two lines:
[upstream] locked_commit→f4de33d06dada4edcf5076dded10e9c303cf597e, the first pkgs commit that has the package. Both the name and the pin are needed; the name alone resolves againstff15baa9, which predates it.[session] packages+=cargo-nextest— the session set is what contributors' sandboxes and the runtime's test sandboxes both read.Blast radius, stated plainly: the pin jumps 65 pkgs commits, and that set includes the toolchain —
gcc,glibc,binutils,openssl,zlib,linux_headers,protobuf,skopeo,curl— andvirtio-linux/virtio-kernel-raw/microvm-rootfs, which the[outputs.*]VM images build from. Thedogfood, KVM and native lanes on this PR are the verification; if one of them objects, the fix is to that package, not to this file.Validated with
tomllib(parses;session.packages=["just", "shellcheck", "python", "cargo-nextest"]).mip checkis Linux-only, so CI'sminimal-checkjob is the schema check here.🤖 Generated with Claude Code
Summary by CodeRabbit