Repository navigation
fix: Do not fabricate missing read-only patch sources - #1540
norrietaylor merged 1 commit into
Conversation
Read-only patch mappings consume a source that must already exist, but to_fs_mappings set create_if_missing unconditionally, so a missing ro path was silently created as an empty directory and the task ran against nothing, exiting 0. Derive the flag from the mapping mode: false for ro, true for rw. sandbox2 already errors when create_if_missing is false, so a missing ro source now fails at spawn naming the host path.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthrough
ChangesFilesystem mapping behavior
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The mapping change correctly distinguishes missing read-only and read-write sources, with coverage for both files and directories. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit checks each mapped path, Comment |
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABR5q2SQ
Read-only patch mappings consume a source that must already exist, but
to_fs_mappingssetcreate_if_missingunconditionally, so a missingropath was silently created as an empty directory and the task ran against nothing, exiting 0. Derive the flag from the mapping mode:falseforro,trueforrw.sandbox2already errors whencreate_if_missingis false, so a missingrosource now fails at spawn naming the host path.Verification
cargo fmt --all --check --manifest-path target/Cargo.toml — ok
cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings — ok
cargo build --workspace --locked --manifest-path target/Cargo.toml — ok
cargo test --workspace --locked --manifest-path target/Cargo.toml — ok (2 pre-existing
checkoutsfailures on unmodified main: git clone collisions in /tmp)cargo test -p mfile — 65 passed, 0 failed (includes new to_fs_mappings_derives_create_if_missing_from_the_mode)
Summary by CodeRabbit