Repository navigation
[worker:doc-drift] add missing crates to architecture.md crate map - #1336
gominimal-aw-bot[bot] merged 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe architecture crate map now documents the ChangesCrate map documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This documentation-only change adds the three missing workspace crates to the architecture map without affecting runtime behavior or build outputs. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the issue, documents the three added crates, describes the documentation-only scope, and records verification details. It does not reproduce the template headings or checklist, but the required information is mostly present. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
minimal-review — advisory review
Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.
Scope: matches intent exactly — one table in docs/architecture.md gains the three rows (minimal-client, minimal-tui, mlog) that AGENTS.md's own crate map already documents but §3 was missing, per issue #1322. No source, Cargo.toml, or workflow files touched.
Clobber: none. git log on this file shows no recent work being reverted; this is a pure addition.
Correctness: verified all three new rows against AGENTS.md's canonical table — area assignments (session/session/shared) and role descriptions match. Alphabetical ordering is preserved at both insertion points (minimal → minimal-client → minimal-tui → minimald, and mip → mlog → op). The table now totals 31 rows, matching the crate count stated elsewhere in the docs.
Nothing to flag. This is a well-scoped, accurate doc fix.
What ran
5 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. diff scope check — self-reported
pr.diff touches only docs/architecture.md, matching changed_files in pr.json and the PR's stated doc-only intent.
2. rg for the three added crate names in AGENTS.md — self-reported
AGENTS.md's own crate-map table (root, checked-in canonical doc) already lists
minimal-client,minimal-tui, andmlogwith the exact same area assignments (session, session, shared) and near-identical role text now added to docs/architecture.md §3. The added rows are consistent with the existing canonical source, not invented.
**3. grep -c '^| ' over docs/architecture.md lines 196-229 (the §3 table body)** — exit 0` · self-reported
Table now has exactly 31 data rows, matching AGENTS.md's and the PR body's stated total of 31 workspace crates.
4. manual check of alphabetical ordering around the three insertion points — self-reported
ASCII ordering confirms
minimal<minimal-client<minimal-tui<minimald(hyphen 0x2D sorts before any letter) andmip<mlog<op, so the new rows preserve the table's existing alphabetical order rather than breaking it.
5. git log --oneline -15 -- docs/architecture.md — exit 0 · self-reported
History shows only this PR's own commit (86ec776) on top of the prior doc-architecture-v2 rewrite (6a06f58); nothing recent is reverted or overwritten by this change.
minimal-review · schema minimal-review/v1 · persona generalist · model claude-sonnet-5 via claude-code · prompt review-prompt/v2 · head d7e065c1545e · verdict COMMENT · 0 finding(s), 0 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
Resolves the doc-drift finding in
gominimal/minimal#1322: the §3 "Crate map" indocs/architecture.mdlisted only 28 of the workspace's 31 crates, silently omitting three real workspace members.AGENTS.mdstates there are 31 crates and points readers at §3 as the authoritative long-form map, so the omission would lead an agent or contributor to conclude these crates do not exist.Fix
Added the three missing rows to the §3 table, preserving its alphabetical ordering and matching the plane assignments and role text already documented in
AGENTS.md:minimal-client(session) — inserted betweenminimalandminimaldminimal-tui(session) — inserted betweenminimal-clientandminimaldmlog(shared) — inserted betweenmipandopThe code is correct; only the doc needed updating. No source,
Cargo.toml, or workflow files were touched.Verification
This is a documentation-only change (a single markdown table in
docs/architecture.md); no.rsorCargo.tomlfiles were modified, so there is no compilation,cargo fmt, orCargo.lockimpact. The host backstop still gates the full suite (fmt-check + build--locked+ clippy-D warnings+ test) before this PR opens, and worker-iterate's CI-fix net auto-corrects any mechanicalfmtfailure or escalates the rest.Closes #1322
Summary by CodeRabbit