8000 chore(deps): update object to 0.40.0 by twitchyliquid64 · Pull Request #1191 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

chore(deps): update object to 0.40.0 - #1191

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/sftp
Aug 10, 2026
Merged

chore(deps): update object to 0.40.0#1191
twitchyliquid64 merged 1 commit into
mainfrom
tom/sftp

Conversation

@twitchyliquid64
@twitchyliquid64 twitchyliquid64 commented Aug 10, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Contributor

Needed to unblock dependabot #1189 due to API change

Note

Update object dependency to 0.40.0 with safer import and export parsing

  • Updates the object crate from 0.39 to 0.40 in Cargo.toml, removing the pinned-version comment.
  • Updates lib_symbols in check/src/lib.rs to collect exports eagerly, propagate parse errors as anyhow errors instead of panicking, and drop ordinal-only exports via into_name().
  • Updates MissingRuntimeDeps::check in check/src/outputs.rs to iterate the lazy imports iterator, skip malformed entries with a warning, and ignore ordinal-only imports via into_name().
  • Behavioral Change: lib_symbols now returns an error on export parse failure (previously panicked); both methods now silently drop ordinal-only symbols.

Macroscope summarized 80986ad.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with updated binary parsing dependencies.
    • ELF export validation now handles malformed entries without crashing and ignores unnamed ordinal-only exports.
    • Dependency checks now continue when encountering malformed or unresolved imports, while still validating named imports.
    • Improved detection of relevant runtime symbols in supported binaries.

@twitchyliquid64
twitchyliquid64 requested a review from a team as a code owner August 10, 2026 17:33
@coderabbitai
coderabbitai Bot commented Aug 10, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The workspace upgrades object to 0.40. The checker now validates export iterator results, filters ordinal-only exports, and continues scanning after malformed or ordinal-only imports.

Changes

Object export and import handling

Layer / File(s) Summary
Export processing
Cargo.toml, crates/check/src/lib.rs		 The workspace uses object 0.40. ELF export processing reports malformed entries, ignores unnamed ordinal exports, and applies glibc stub detection to named exports.
Import processing
crates/check/src/outputs.rs		 Import scanning logs malformed entries and continues. It ignores ordinal-only imports and validates named imports as before.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: bryan-minimal

Poem

A rabbit checks each export name,
Skips nameless hops without blame.
Broken imports warn, then pass,
Named symbols safely cross the grass.
Object grows, and checks stay bright.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the dependency update and API rationale, but it omits the required Testing and Checklist sections. Add the required Summary, Testing, and Checklist sections, including test commands and checklist status.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the dependency update and follows the repository's Conventional Commit format.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/sftp

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (rebase) August 10, 2026 17:47
< 8000 /div>
bryan-minimal
bryan-minimal approved these changes Aug 10, 2026
View reviewed changes
@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 merged commit ca07456 into main Aug 10, 2026
30 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/sftp branch August 10, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanspearman evanspearman evanspearman approved these changes
@bryan-minimal bryan-minimal bryan-minimal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twitchyliquid64 @evanspearman @bryan-minimal
0